Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix query statement detail error cause by round #806

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

crazycs520
Copy link
Collaborator

Signed-off-by: crazycs520 crazycs520@gmail.com

When query statement detail, dashboard uses to use ROUND function to query, but it may cause the flowing error:

image

This is caused by the ROUND function result is float64, not int, here is an example.

test> create table t (a int, b double);
Query OK, 0 rows affected
Time: 0.044s
test> insert into t values (62695, 2240325.4838709678),(6, 0.0);
Query OK, 2 rows affected
Time: 0.042s
test> select round(sum(a*b)/sum(a)) as avg from t;
+-----------+
| avg       |
+-----------+
| 2240111.0 |
+-----------+

This PR use CAST( ... AS SIGNED) function instead of ROUND when query statement detail.

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Collaborator Author

@breeswish @baurine PTAL

@breezewish breezewish merged commit e483ba9 into pingcap:master Nov 24, 2020
breezewish pushed a commit that referenced this pull request Nov 26, 2020
Signed-off-by: crazycs520 <crazycs520@gmail.com>
breezewish added a commit that referenced this pull request Nov 26, 2020
* misc: Increase ulimit to 65535 for test env (#756)
* test: Fix frontend CI (#752)
* ui: fix dayjs i18n (#755)
* ui: handle error globally (#757)
* statement, slow_query: support all fields in list page (#749)
* ui: memorize expand/collapse full text in detail pages (#775)
* ui: break loop dependencies (#771)
* ui: fix browser compatibility check (#776)
* ui: Refine store location, add zoom and pan (#772)
* ui: show disk usage information for statement and slow query (#777)
* ui: use qps instead of ops (#786)
* statement: support export (#778)
*: Fix slow query and start_ts not working in some cases (#793)
* ui: fix errors doesn't display (#794)
* ui: fix the error message doesn't show correct (#799)
* slow_queries: support export (#792)
* ui: add MySqlFormatter to customize the sql formatter (#805)
*: fix query statement detail error cause by round (#806)
* ui: copy original content instead of formatted content for CopyLink (#802)
* add min height of topology canvas (#804)
* metrics: Support customize Prometheus address (#808)
* clusterinfo: Refine (#815)
* ui: Open statement and slow log in new tab (#816)
* ui: add more time field for slow query detail page (#810)
* slowlog: Improve descriptions (#817)
* build: add action to check release-version is changed for release branch
* Release v2020.11.26.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants