Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

backend: fix a bug about wrong column info #420

Merged
merged 4 commits into from
Oct 23, 2020
Merged

backend: fix a bug about wrong column info #420

merged 4 commits into from
Oct 23, 2020

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

fix a bug about wrong column info

What is changed and how it works?

Check List

Tests

  • Unit test

glorv
glorv reviewed Oct 13, 2020
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm
Copy link
Collaborator

kennytm commented Oct 16, 2020

LGTM after fixing overvenus's comment.

@kennytm kennytm added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) status/WIP Work in progress labels Oct 16, 2020
@glorv glorv added this to the v4.0.8 milestone Oct 19, 2020
@zier-one zier-one removed the status/WIP Work in progress label Oct 22, 2020
@zier-one
Copy link
Contributor Author

/run-all-tests

@glorv
Copy link
Contributor

glorv commented Oct 22, 2020

/run-all-tests

2 similar comments
@glorv
Copy link
Contributor

glorv commented Oct 22, 2020

/run-all-tests

@glorv
Copy link
Contributor

glorv commented Oct 22, 2020

/run-all-tests

@kennytm
Copy link
Collaborator

kennytm commented Oct 22, 2020

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/lightning_ghpr_test/detail/lightning_ghpr_test/2287/pipeline

[2020-10-22T08:57:36.890Z] Import using importer finished
[2020-10-22T08:57:37.149Z] TEST FAILED: OUTPUT DOES NOT CONTAIN 'set: x00,x06,x07,x09,x17,x20,x23,x24,x27,x37,x44,x46,x49,x54,x55,x58,x61,x62'
[2020-10-22T08:57:37.149Z] ____________________________________
[2020-10-22T08:57:37.149Z] [Thu Oct 22 16:57:36 CST 2020] Executing SQL: SELECT `set` FROM vt.`enum-set` WHERE `enum` = "gcc"
[2020-10-22T08:57:37.149Z] *************************** 1. row ***************************
[2020-10-22T08:57:37.149Z] set: x10,x17,x20,x23,x24,x27,x37,x44,x46,x49,x54,x55,x58,x61,x62
[2020-10-22T08:57:37.149Z] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This looks broken.

@glorv glorv mentioned this pull request Oct 23, 2020
Merged
glorv
glorv approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glorv glorv merged commit 5b212bf into master Oct 23, 2020
@glorv glorv deleted the leoppro/fix_bug branch October 23, 2020 05:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@glorv glorv glorv approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Milestone
v4.0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@zier-one @kennytm @glorv @overvenus