Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

test: fix a unstable integration test #426

Merged
merged 1 commit into from
Oct 23, 2020
Merged

test: fix a unstable integration test #426

merged 1 commit into from
Oct 23, 2020

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Oct 23, 2020

What problem does this PR solve?

When investigating the test failure in #420, I found if we run 'new_collation row-format-v2 various_types' these three tests together, the last test will fail stably.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • manual test (run TEST_NAME='new_collation row-format-v2 various_types' tests/run.sh)

Side effects

Related changes

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) label Oct 23, 2020
@kennytm kennytm merged commit c11e6bd into master Oct 23, 2020
@kennytm kennytm deleted the fix-test branch October 23, 2020 04:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants