Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-prepared plan cache (Stage 1) #36598

Closed
Reminiscent opened this issue Jul 27, 2022 · 1 comment · Fixed by #36844, #37028 or #46504
Closed

Support non-prepared plan cache (Stage 1) #36598

Reminiscent opened this issue Jul 27, 2022 · 1 comment · Fixed by #36844, #37028 or #46504
Assignees
@qw4990 @Reminiscent @fzzf678
Labels
epic/plan-cache sig/planner SIG: Planner type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@Reminiscent
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

TP queries can get lots of performance benefits from Plan Cache, but the current TiDB Plan Cache can only support Prepare/Execute Statements. Most of our users are still using general queries to access TiDB instead of Prepare/Execute. So if Plan Cache can support general queries, these users can gain some performance benefits as well.

Describe the feature you'd like:

When we execute the general query, we can skip the parser and optimizer phase to directly get the physical plan from the plan cache. That can save more time for the TP queries.

Teachability, Documentation, Adoption, Migration Strategy:

The detail design will be posted later.
@Reminiscent Reminiscent added sig/planner SIG: Planner type/feature-request Categorizes issue or PR as related to a new feature. epic/plan-cache labels Jul 27, 2022
@Reminiscent Reminiscent mentioned this issue Jul 27, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jul 27, 2022
@Reminiscent
planner: refactor the execute path when using plan cache (#36587)
16f143f 
ref #36598
@fzzf678
Copy link
Contributor

fzzf678 commented Jul 27, 2022

/assign @fzzf678

@fzzf678 fzzf678 mentioned this issue Jul 27, 2022
Merged
12 tasks
@Reminiscent Reminiscent mentioned this issue Jul 27, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jul 28, 2022
@fzzf678
planner: refactor the function (#36603)
7eb79e6 
ref #36598
@Reminiscent Reminiscent mentioned this issue Aug 1, 2022
Merged
12 tasks
@fzzf678 fzzf678 mentioned this issue Aug 1, 2022
Merged
12 tasks
@qw4990 qw4990 mentioned this issue Aug 2, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Aug 2, 2022
@fzzf678
planner: update plan cache key and value (#36779)
c8cb3c9 
ref #36598
@fzzf678 fzzf678 mentioned this issue Aug 2, 2022
Merged
12 tasks
@qw4990 qw4990 mentioned this issue Aug 3, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Aug 3, 2022
@fzzf678
planner: update plan cache key (#36813)
43c1515 
ref #36598
@qw4990 qw4990 mentioned this issue Aug 3, 2022
Closed
12 tasks
ti-chi-bot pushed a commit that referenced this issue Aug 3, 2022
@Reminiscent
planner: refactor the IsolationReadEngines variable for plan cache (#…
3847d9e 
…36770)

ref #36598
ti-chi-bot pushed a commit that referenced this issue Aug 3, 2022
@qw4990
planner: remove the useless variable tidb_enable_point_get_cache (#…
bd3d138 
…36844)

close #36598
@qw4990 qw4990 mentioned this issue Aug 4, 2022
Merged
12 tasks
@Reminiscent Reminiscent mentioned this issue Aug 4, 2022
Closed
12 tasks
ti-chi-bot pushed a commit that referenced this issue Aug 4, 2022
@qw4990
planner: clean useless Plan Cache code of binary protocol parameters (#…
5e00a15 
…36887)

ref #36598
@fzzf678 fzzf678 mentioned this issue Aug 4, 2022
Merged
12 tasks
@qw4990 qw4990 mentioned this issue Aug 5, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Aug 5, 2022
@fzzf678
planner: unify the parameters name in plan cache (#36899)
d760746 
ref #36598
@fzzf678 fzzf678 mentioned this issue Aug 5, 2022
Closed
12 tasks
ti-chi-bot pushed a commit that referenced this issue Aug 8, 2022
@qw4990
planner: support session level for the variable tidb_enable_prepared_…
244b353 
…plan_cache (#36923)

ref #36598
@Reminiscent Reminiscent reopened this Aug 8, 2022
ti-chi-bot pushed a commit that referenced this issue Apr 17, 2023
@qw4990
planner: add more test cases for non-prep plan cache (#43083)
8e7ebb3 
ref #36598
ti-chi-bot pushed a commit that referenced this issue Apr 17, 2023
@qw4990
planner: non-prep and prep statements use the same unified plan cache (…
b1e6fe7 
…#43094)

ref #36598
@qw4990 qw4990 mentioned this issue Apr 18, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 18, 2023
@qw4990
planner: make LRUPlanCache.Close reenterable (#43117)
e123433 
ref #36598
This was referenced Apr 18, 2023
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Apr 18, 2023
@qw4990
planner: introduce a new variable tidb_session_plan_cache_size (#43140
6d6c607 
)

ref #36598
@qw4990 qw4990 mentioned this issue Apr 18, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 18, 2023
@qw4990
planner: optimize the performance of GetParamSQLFromAST for non-pre…
c5cb7d2 
…p plan cache (#43161)

ref #36598
This was referenced Apr 19, 2023
Closed
Closed
Merged
ti-chi-bot pushed a commit that referenced this issue Apr 19, 2023
@qw4990
planner: performance optimization for plan-cache (#43183)
7dd8ef6 
ref #36598
ti-chi-bot pushed a commit that referenced this issue Apr 19, 2023
@qw4990
planner: enable non-prep plan cache by default (#43145)
cd33faf 
ref #36598
@qw4990 qw4990 changed the title Support non-prepared plan cache Support non-prepared plan cache (Stage 1) Apr 19, 2023
@qw4990 qw4990 mentioned this issue Apr 20, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 20, 2023
@qw4990
planner: fix unsafe sync.Pool used in non-prep plan cache (#43242)
9fcf6b9 
ref #36598
This was referenced Apr 20, 2023
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Apr 20, 2023
@qw4990
planner: disable non-prep plan cache for DML statements for now (#43258)
78c50dc 
ref #36598
qw4990 added a commit to qw4990/tidb that referenced this issue Apr 21, 2023
@qw4990
planner: disable non-prep plan cache for DML statements for now (ping…
3aa4d02 
…cap#43258)

ref pingcap#36598
@qw4990 qw4990 mentioned this issue Apr 21, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 21, 2023
@qw4990
planner: disable non-prep plan cache for DML statements for now (#43258…
2dd5ea9 
…) (#43274)

ref #36598
@qw4990 qw4990 mentioned this issue May 17, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 17, 2023
@qw4990
planner: enable non-prep plan cache by default on Master (#43904)
a1f0097 
ref #36598
@qw4990 qw4990 mentioned this issue Aug 30, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 30, 2023
@qw4990
planner: disable non-prep plan cache by default (#46504)
61f8825 
close #36598
@qw4990 qw4990 mentioned this issue Sep 4, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 5, 2023
@qw4990
planner: add more test for plan cache (#46640)
d4d025c 
ref #36598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qw4990 qw4990

@Reminiscent Reminiscent

@fzzf678 fzzf678

Labels
epic/plan-cache sig/planner SIG: Planner type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
3 participants
@qw4990 @Reminiscent @fzzf678