Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add more test cases for non-prep plan cache #43083

Merged
merged 7 commits into from
Apr 17, 2023
Merged

planner: add more test cases for non-prep plan cache #43083

merged 7 commits into from
Apr 17, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 17, 2023

What problem does this PR solve?

Issue Number: ref #36598

Problem Summary: planner: add more test cases for non-prep plan cache

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzzf678
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2023
@qw4990 qw4990 added sig/planner SIG: Planner epic/plan-cache and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2023
qw4990
qw4990 commented Apr 17, 2023
View reviewed changes
executor/issuetest/executor_issue_test.go
@@ -682,7 +682,7 @@ func TestIssue22231(t *testing.T) {
tk.MustExec("create table t_issue_22231(a datetime)")
tk.MustExec("insert into t_issue_22231 values('2020--05-20 01:22:12')")
tk.MustQuery("select * from t_issue_22231 where a >= '2020-05-13 00:00:00 00:00:00' and a <= '2020-05-28 23:59:59 00:00:00'").Check(testkit.Rows("2020-05-20 01:22:12"))
tk.MustQuery("show warnings").Check(testkit.Rows("Warning 1292 Truncated incorrect datetime value: '2020-05-13 00:00:00 00:00:00'", "Warning 1292 Truncated incorrect datetime value: '2020-05-28 23:59:59 00:00:00'"))
tk.MustQuery("show warnings").MultiCheckContain([]string{"Truncated incorrect datetime value: '2020-05-13 00:00:00 00:00:00'", "Truncated incorrect datetime value: '2020-05-28 23:59:59 00:00:00'"})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepare to enable this switch by default in the future.

qw4990
qw4990 commented Apr 17, 2023
View reviewed changes
planner/core/plan_cache_param.go
Comment on lines +75 to +76
param := ast.NewParamMarkerExpr(len(pr.params) - 1) // offset is used as order in non-prepared plan cache.
n.Datum.Copy(&param.(*driver.ParamMarkerExpr).Datum) // init the ParamMakerExpr's Datum
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce one time of data copy.

qw4990
qw4990 commented Apr 17, 2023
View reviewed changes
planner/core/plan_cache_utils.go Outdated
Comment on lines 219 to 220
dbBytes = hack.Slice(key.stmtText)
bufferSize = len(dbBytes) * 2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce times of buffer re-allocation.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 17, 2023
hawkingrei
hawkingrei reviewed Apr 17, 2023
View reviewed changes
planner/core/plan_cache_utils.go Outdated
dbBytes = hack.Slice(key.database)
bufferSize = len(dbBytes) + 8*6 + 3*8
dbBytes = hack.Slice(key.stmtText)
bufferSize = len(dbBytes) * 2
)
if key.hash == nil {
key.hash = make([]byte, 0, bufferSize)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may use sync.Pool to improve performance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I add a TODO comment there.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 17, 2023
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 29075d8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 876583e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test mysql-test

@hawkingrei
Copy link
Member

/test all

1 similar comment
@hawkingrei
Copy link
Member

/test all

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/merge

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1a46daa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test mysql-test

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test mysql-test

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test check-dev2

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test check-dev2

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test check-dev2

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test check-dev2

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 95d200c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test check-dev2

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test mysql-test

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test mysql-test

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test mysql-test

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test mysql-test

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/merge

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2023

/test unit-test

@ti-chi-bot ti-chi-bot merged commit 8e7ebb3 into pingcap:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@fzzf678 fzzf678 fzzf678 approved these changes

Assignees
No one assigned
Labels
epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @ti-chi-bot @hawkingrei @fzzf678