Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: add unit test for plugin #10506

Merged
merged 4 commits into from
Jun 10, 2019
Merged

plugin: add unit test for plugin #10506

merged 4 commits into from
Jun 10, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented May 16, 2019 •
edited
Loading

What problem does this PR solve?

add unit test

What is changed and how it works?

add unit test

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • test

Side effects

  • N/A

Related changes

  • N/A

This change is Reviewable

@codecov
Copy link

codecov bot commented May 16, 2019 •
edited
Loading

Codecov Report

Merging #10506 into master will increase coverage by 0.1858%.
The diff coverage is 27.5862%.

@@               Coverage Diff               @@
##            master     #10506        +/-   ##
===============================================
+ Coverage   79.564%   79.7498%   +0.1858%     
===============================================
  Files          415        415                
  Lines        88266      88266                
===============================================
+ Hits         70228      70392       +164     
+ Misses       12841      12662       -179     
- Partials      5197       5212        +15

@mahjonp
Copy link
Contributor

mahjonp commented May 16, 2019

/rebuild

1 similar comment
@lysu
Copy link
Contributor Author

lysu commented May 16, 2019

/rebuild

@lysu
Copy link
Contributor Author

lysu commented May 20, 2019

/run-all-tests tidb-test=pr/822

@tiancaiamao
Copy link
Contributor

/run-unit-test

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2019
@lysu lysu requested a review from jackysp June 10, 2019 06:55
jackysp
jackysp approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 2ee59f1 into pingcap:master Jun 10, 2019
This was referenced Jul 10, 2019
Merged
Merged
ngaut pushed a commit that referenced this pull request Jul 15, 2019
@lysu @ngaut
plugin: support dynamic enable/disable plugins(#11122)(#10923)(#10506) (
aeed234 
#11189)

* plugin: add unit test for plugin (#10506)

* plugin: setup connection info in session when audit plugin be enabled (#10923)

*  plugin: support dynamic enable/disable plugins (#11122)

* update parser version & fix cp compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
component/plugin component/test status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysu @mahjonp @tiancaiamao @jackysp