plugin: setup connection info in session when audit plugin be enabled #10923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10923 +/- ##
===========================================
Coverage 80.9115% 80.9115%
===========================================
Files 418 418
Lines 89384 89384
===========================================
Hits 72322 72322
Misses 11827 11827
Partials 5235 5235 |
tiancaiamao
reviewed
Jun 26, 2019
| @@ -385,6 +385,9 @@ type SessionVars struct { | |||
|
|
|||
| // Killed is a flag to indicate that this query is killed. | |||
| Killed uint32 | |||
|
|
|||
| // ConnectionInfo indicates current connection info used by current session, only be lazy assigned by plugin. | |||
| ConnectionInfo *ConnectionInfo | |||
There was a problem hiding this comment.
How about saving it to clientConn?
It's not used in sessionVars anyway.
There was a problem hiding this comment.
@tiancaiamao clientConn is not easy to obtain in the later process phase(e.g. write audit log after a query finished - - ), it will be used in audit plugin's OnGeneralEvent
|
LGTM |
tiancaiamao
added
status/LGT2
tiancaiamao
approved these changes
Jun 27, 2019
jackysp
pushed a commit
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
audit plugin need using extra connection info for every log record, connInfo is static data for every session, but tidb instance without plugin doesn't need it.
What is changed and how it works?
IsEnablemethod to pluginCheck List
Tests
Code changes
Side effects
Related changes
This change is