build: use make testSuite to ensure all testSuites enabled
#11627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunRunAway
added
type/bugfix
|
/run-all-tests |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11627 +/- ##
================================================
- Coverage 81.4775% 81.2599% -0.2177%
================================================
Files 428 426 -2
Lines 92380 92054 -326
================================================
- Hits 75269 74803 -466
- Misses 11739 11877 +138
- Partials 5372 5374 +2 |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
|
/run-unit-test |
zz-jason
reviewed
Aug 6, 2019
| @@ -37,6 +37,6 @@ func (s *testBackoffSuite) TearDownTest(c *C) { | |||
| func (s *testBackoffSuite) TestBackoffWithMax(c *C) { | |||
| b := NewBackoffer(context.TODO(), 2000) | |||
| err := b.BackoffWithMaxSleep(boTxnLockFast, 30, errors.New("test")) | |||
| c.Assert(err, NotNil) | |||
| c.Assert(err, IsNil) | |||
There was a problem hiding this comment.
why this test result is changed?
There was a problem hiding this comment.
This test case fails but never runs once before :(
|
How about cherry-pick this commit to the release branch? |
|
@SunRunAway Please follow CONTRIBUTING.md to refine the PR title. |
SunRunAway
changed the title
make testSuite to ensure all testSuites enabledmake testSuite to ensure all testSuites enabled
alivxxx
reviewed
Aug 8, 2019
alivxxx
added
status/can-merge
alivxxx
added
status/LGT2
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #11685 |
SunRunAway
added a commit
to SunRunAway/tidb
that referenced
this pull request
Aug 8, 2019
sre-bot
pushed a commit
that referenced
this pull request
Aug 8, 2019
sre-bot
added a commit
that referenced
this pull request
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
use
make testSuiteto ensure all testSuites enabledWhat is changed and how it works?
add a bash script in ./tools/check/check_testSuite.sh
Check List
Tests
Code changes
Side effects
Related changes