Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use make testSuite to ensure all testSuites enabled (#11627) #11685

Merged
merged 11 commits into from
Aug 12, 2019
Merged

build: use make testSuite to ensure all testSuites enabled (#11627) #11685

merged 11 commits into from
Aug 12, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 8, 2019

cherry-pick #11627 to release-3.0

What problem does this PR solve?

use make testSuite to ensure all testSuites enabled

What is changed and how it works?

add a bash script in ./tools/check/check_testSuite.sh

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • The script runs a little slowly.

Related changes

  • None

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 8, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Aug 8, 2019
Merged
@sre-bot sre-bot added component/build component/test type/3.0 cherry-pick type/bugfix This PR fixes a bug. type/enhancement The issue or PR belongs to an enhancement. labels Aug 8, 2019
zz-jason
zz-jason reviewed Aug 8, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alivxxx
alivxxx reviewed Aug 8, 2019
View reviewed changes
executor/executor_test.go Outdated Show resolved Hide resolved
@zz-jason
Copy link
Member

/run-all-tests

@zz-jason
Copy link
Member

zz-jason commented Aug 10, 2019 •
edited
Loading 

executor/executor_test.go:93:53: undefined: baseTestSuite
executor/executor_test.go:93:66: too few values in testSuite literal

@SunRunAway please fix the CI problem.

@SunRunAway
Copy link
Contributor

/run-all-tests

zz-jason
zz-jason reviewed Aug 10, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2019
alivxxx
alivxxx approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 12, 2019

/run-all-tests

@sre-bot sre-bot merged commit bfead96 into pingcap:release-3.0 Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@alivxxx alivxxx alivxxx approved these changes

@lysu lysu Awaiting requested review from lysu

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
component/build component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @zz-jason @SunRunAway @alivxxx