executor: do not use batchChecker in 'insert ignore into ...' #12122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batchChecker is difficult to maintain, we should get rid of it. In this commit I catch the BatchGet result into the snapshot, in this way we can achieve the same goal as the batchChecker
tiancaiamao
added
sig/execution
tiancaiamao
requested review from
lysu and
jackysp
and removed request for
lysu
|
Please resolve the conflicts. |
Codecov Report
@@ Coverage Diff @@
## master #12122 +/- ##
===============================================
+ Coverage 81.382% 81.5083% +0.1262%
===============================================
Files 450 449 -1
Lines 96767 97390 +623
===============================================
+ Hits 78751 79381 +630
+ Misses 12392 12385 -7
Partials 5624 5624 |
|
/run-all-tests |
lysu
reviewed
Sep 10, 2019
| @@ -149,9 +149,9 @@ func prefetchDataCache(ctx context.Context, txn kv.Transaction, rows []toBeCheck | |||
| return prefetchConflictedOldRows(ctx, txn, rows, values) | |||
| } | |||
|
|
|||
| // updateDupRowNew updates a duplicate row to a new row. | |||
| func (e *InsertExec) updateDupRowNew(ctx context.Context, txn kv.Transaction, row toBeCheckedRow, handle int64, onDuplicate []*expression.Assignment) error { | |||
| oldRow, err := e.getOldRowNew(ctx, e.ctx, txn, row.t, handle, e.GenExprs) | |||
There was a problem hiding this comment.
so batchChecker) getOldRowNew can be remove now~?
There was a problem hiding this comment.
Not now, the replace ... is still using it.
I'll remove it later...
There was a problem hiding this comment.
tidb/executor/batch_checker.go
Line 297 in dd11b55
lysu
approved these changes
Sep 10, 2019
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Sep 25, 2019
sre-bot
pushed a commit
that referenced
this pull request
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Continue with #12108, please review this PR after it's merged.
After this commit, the insert operations do not use the
batchCheckeranymore.What is changed and how it works?
Refactoring code.
Implement the 'insert ignore into ...' operation without the
batchCheckerCheck List
Tests
Release note