Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: do not use batchChecker in 'insert ignore into ...' (#12122) #12386

Merged
merged 3 commits into from
Sep 25, 2019
Merged

executor: do not use batchChecker in 'insert ignore into ...' (#12122) #12386

merged 3 commits into from
Sep 25, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #12122

@tiancaiamao tiancaiamao added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution type/3.0 cherry-pick labels Sep 25, 2019
@tiancaiamao tiancaiamao requested review from lysu and jackysp and removed request for lysu September 25, 2019 09:37
@tiancaiamao
Copy link
Contributor Author

PTAL @jackysp @lysu

jackysp
jackysp reviewed Sep 25, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2019
lysu
lysu approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 25, 2019
@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Sep 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

Your auto merge job has been accepted, waiting for 12383

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

/run-all-tests

@sre-bot sre-bot merged commit c5fdec7 into pingcap:release-3.0 Sep 25, 2019
@tiancaiamao tiancaiamao deleted the cherry-batch-insert-ignore branch October 9, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiancaiamao @sre-bot @lysu @jackysp @zz-jason