planner/cascades: implement ImplementationRule for Selection

planner/cascades/implementation_rules.go

@@ -52,6 +52,9 @@ var implementationMap = map[memo.Operand][]ImplementationRule{
 	memo.OperandShow: {
 		&ImplShow{},
 	},
+	memo.OperandSelection: {
+		&ImplSelection{},
+	},
 }
 
 // ImplTableDual implements LogicalTableDual as PhysicalTableDual.
@@ -164,3 +167,21 @@ func (r *ImplShow) OnImplement(expr *memo.GroupExpr, reqProp *property.PhysicalP
 	showPhys.SetSchema(logicProp.Schema)
 	return impl.NewShowImpl(showPhys), nil
 }
+
+// ImplSelection is the implementation rule which implements LogicalSelection to PhysicalSelection.
+type ImplSelection struct {
+}
+
+// Match implements ImplementationRule Match interface.
+func (r *ImplSelection) Match(expr *memo.GroupExpr, prop *property.PhysicalProperty) (matched bool) {
+	return true
+}
+
+// OnImplement implements ImplementationRule OnImplement interface.
+func (r *ImplSelection) OnImplement(expr *memo.GroupExpr, reqProp *property.PhysicalProperty) (memo.Implementation, error) {
+	logicalSel := expr.ExprNode.(*plannercore.LogicalSelection)
+	physicalSel := plannercore.PhysicalSelection{
+		Conditions: logicalSel.Conditions,
+	}.Init(logicalSel.SCtx(), expr.Group.Prop.Stats.ScaleByExpectCnt(reqProp.ExpectedCnt), logicalSel.SelectBlockOffset(), reqProp)
+	return impl.NewSelectionImpl(physicalSel), nil
+}

planner/cascades/integration_test.go

@@ -19,12 +19,14 @@ import (
 	"github.com/pingcap/tidb/session"
 	"github.com/pingcap/tidb/store/mockstore"
 	"github.com/pingcap/tidb/util/testkit"
+	"github.com/pingcap/tidb/util/testutil"
 )
 
 var _ = Suite(&testIntegrationSuite{})
 
 type testIntegrationSuite struct {
-	store kv.Storage
+	store    kv.Storage
+	testData testutil.TestData
 }
 
 func newStoreWithBootstrap() (kv.Storage, error) {
@@ -40,9 +42,12 @@ func (s *testIntegrationSuite) SetUpSuite(c *C) {
 	var err error
 	s.store, err = newStoreWithBootstrap()
 	c.Assert(err, IsNil)
+	s.testData, err = testutil.LoadTestSuiteData("testdata", "integration_suite")
+	c.Assert(err, IsNil)
 }
 
 func (s *testIntegrationSuite) TearDownSuite(c *C) {
+	c.Assert(s.testData.GenerateOutputIfNeeded(), IsNil)
 	s.store.Close()
 }
 
@@ -62,22 +67,22 @@ func (s *testIntegrationSuite) TestPKIsHandleRangeScan(c *C) {
 	tk := testkit.NewTestKitWithInit(c, s.store)
 	tk.MustExec("drop table if exists t")
 	tk.MustExec("create table t(a int primary key, b int)")
-	tk.MustExec("insert into t values(1,2),(3,4)")
+	tk.MustExec("insert into t values(1,2),(3,4),(5,6)")
 	tk.MustExec("set session tidb_enable_cascades_planner = 1")
-	tk.MustQuery("explain select b from t where a > 1").Check(testkit.Rows(
-		"Projection_8 3333.33 root Column#2",
-		"└─TableReader_9 3333.33 root data:TableScan_10",
-		"  └─TableScan_10 3333.33 cop table:t, range:(1,+inf], keep order:false, stats:pseudo",
-	))
-	tk.MustQuery("select b from t where a > 1").Check(testkit.Rows(
-		"4",
-	))
-	tk.MustQuery("explain select b from t where a > 1 and a < 3").Check(testkit.Rows(
-		"Projection_8 2.00 root Column#2",
-		"└─TableReader_9 2.00 root data:TableScan_10",
-		"  └─TableScan_10 2.00 cop table:t, range:(1,3), keep order:false, stats:pseudo",
-	))
-	tk.MustQuery("select b from t where a > 1 and a < 3").Check(testkit.Rows())
+
+	var input []string
+	var output []struct {
+		SQL    string
+		Result []string
+	}
+	s.testData.GetTestCases(c, &input, &output)
+	for i, sql := range input {
+		s.testData.OnRecord(func() {
+			output[i].SQL = sql
+			output[i].Result = s.testData.ConvertRowsToStrings(tk.MustQuery(sql).Rows())
+		})
+		tk.MustQuery(sql).Check(testkit.Rows(output[i].Result...))
+	}
 }
 
 func (s *testIntegrationSuite) TestBasicShow(c *C) {

planner/cascades/testdata/integration_suite_in.json

@@ -0,0 +1,15 @@
+[
+  {
+    "name": "TestPKIsHandleRangeScan",
+    "cases": [
+      "explain select b from t where a > 1",
+      "select b from t where a > 1",
+      "explain select b from t where a > 1 and a < 3",
+      "select b from t where a > 1 and a < 3",
+      "explain select b from t where a > 1 and b < 6",
+      "select b from t where a > 1 and b < 6",
+      "explain select a from t where a * 3 + 1 > 9 and a < 5",
+      "select a from t where a * 3 + 1 > 9 and a < 5"
+    ]
+  }
+]

planner/cascades/testdata/integration_suite_out.json

@@ -0,0 +1,64 @@
+[
+  {
+    "Name": "TestPKIsHandleRangeScan",
+    "Cases": [
+      {
+        "SQL": "explain select b from t where a > 1",
+        "Result": [
+          "Projection_8 3333.33 root Column#2",
+          "└─TableReader_9 3333.33 root data:TableScan_10",
+          "  └─TableScan_10 3333.33 cop table:t, range:(1,+inf], keep order:false, stats:pseudo"
+        ]
+      },
+      {
+        "SQL": "select b from t where a > 1",
+        "Result": [
+          "4",
+          "6"
+        ]
+      },
+      {
+        "SQL": "explain select b from t where a > 1 and a < 3",
+        "Result": [
+          "Projection_8 2.00 root Column#2",
+          "└─TableReader_9 2.00 root data:TableScan_10",
+          "  └─TableScan_10 2.00 cop table:t, range:(1,3), keep order:false, stats:pseudo"
+        ]
+      },
+      {
+        "SQL": "select b from t where a > 1 and a < 3",
+        "Result": null
+      },
+      {
+        "SQL": "explain select b from t where a > 1 and b < 6",
+        "Result": [
+          "Projection_9 2666.67 root Column#2",
+          "└─TableReader_10 2666.67 root data:Selection_11",
+          "  └─Selection_11 2666.67 cop lt(Column#2, 6)",
+          "    └─TableScan_12 3333.33 cop table:t, range:(1,+inf], keep order:false, stats:pseudo"
+        ]
+      },
+      {
+        "SQL": "select b from t where a > 1 and b < 6",
+        "Result": [
+          "4"
+        ]
+      },
+      {
+        "SQL": "explain select a from t where a * 3 + 1 > 9 and a < 5",
+        "Result": [
+          "Projection_9 4.00 root Column#1",
+          "└─TableReader_10 4.00 root data:Selection_11",
+          "  └─Selection_11 4.00 cop gt(plus(mul(Column#1, 3), 1), 9)",
+          "    └─TableScan_12 5.00 cop table:t, range:[-inf,5), keep order:false, stats:pseudo"
+        ]
+      },
+      {
+        "SQL": "select a from t where a * 3 + 1 > 9 and a < 5",
+        "Result": [
+          "3"
+        ]
+      }
+    ]
+  }
+]

planner/implementation/simple_plans.go

@@ -15,9 +15,10 @@ package implementation
 
 import (
 	plannercore "github.com/pingcap/tidb/planner/core"
+	"github.com/pingcap/tidb/planner/memo"
 )
 
-// ProjectionImpl implementation of PhysicalProjection.
+// ProjectionImpl is the implementation of PhysicalProjection.
 type ProjectionImpl struct {
 	baseImpl
 }
@@ -36,3 +37,20 @@ type ShowImpl struct {
 func NewShowImpl(show *plannercore.PhysicalShow) *ShowImpl {
 	return &ShowImpl{baseImpl: baseImpl{plan: show}}
 }
+
+// SelectionImpl is the implementation of PhysicalSelection.
+type SelectionImpl struct {
+	baseImpl
+}
+
+// CalcCost implements Implementation CalcCost interface.
+func (sel *SelectionImpl) CalcCost(outCount float64, childCosts []float64, children ...*memo.Group) float64 {
+	// TODO: When CPUFactor and CopCPUFactor can be set by users, we need to distinguish them.
+	sel.cost = outCount*plannercore.CPUFactor + childCosts[0]
+	return sel.cost
+}
+
+// NewSelectionImpl creates a new SelectionImpl.
+func NewSelectionImpl(sel *plannercore.PhysicalSelection) *SelectionImpl {
+	return &SelectionImpl{baseImpl{plan: sel}}
+}