Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor,sessionctx: add correctness for system variables (#12311) #12588

Merged
merged 1 commit into from
Oct 10, 2019
Merged

executor,sessionctx: add correctness for system variables (#12311) #12588

merged 1 commit into from
Oct 10, 2019

Conversation

xiaoronglv
Copy link

@xiaoronglv xiaoronglv commented Oct 10, 2019 •
edited
Loading

What problem does this PR solve?

For MySQL, thread_pool_size is the number of thread groups, which determine how many queries can execute simultaneously.

This commit is to add constraints for global variable thread_pool_size for TiDB, which is a subtask of epic Complete correctness for system.

What is changed and how it works?

Add restriction for global variable thread_pool_size, of which

  • the value must be equal or greater than 1
  • the value must be equal or less than 64

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

  • Possible performance regression
  • Increased code complexity

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 10, 2019
@xiaoronglv
Copy link
Author

/run-all-tests

@xiaoronglv xiaoronglv mentioned this pull request Oct 10, 2019
Merged
@xiaoronglv
Copy link
Author

Hi @zz-jason

This commit is going to cherry-pick a commit from master to release-3.1.

Please help to review my code.

Thanks,

Ryan

zz-jason
zz-jason reviewed Oct 10, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement. labels Oct 10, 2019
@zz-jason zz-jason requested a review from qw4990 October 10, 2019 07:43
qw4990
qw4990 approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 10, 2019

Sorry @qw4990, you don't have permission to trigger auto merge event on this branch.

@zz-jason zz-jason merged commit 68e70bf into pingcap:release-3.1 Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaoronglv @sre-bot @zz-jason @qw4990