Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete correctness for system variables #7195

Closed
spongedu opened this issue Jul 30, 2018 · 6 comments
Closed

Complete correctness for system variables #7195

spongedu opened this issue Jul 30, 2018 · 6 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@spongedu
Copy link
Contributor

spongedu commented Jul 30, 2018

In #7117 we add a framework to validate input when set system variables, but not all system variables are checked in that pr because there are too much of them. We should complete these checks step by step.

What to do:

  1. Find out the specific limitation in MySQL system variable reference
  2. Add related validation in method ValidateSetSystemVar in sessionctx/variable/varsutil.go
  3. Add related tests in executor/set_test.go

Notes:

  1. Details about MySQL system variables can be found here
  2. executor,sessionctx: Add correctness for more system variables #7196 be be referd as an example.
  3. System variables with ScopeNone scope need not be checked because they can't be changed dynamically.
@spongedu
Copy link
Contributor Author

@shenli @zz-jason I think this issue can be marked as for-new-contributors ?

@zz-jason
Copy link
Member

sure!

@zz-jason zz-jason added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jul 30, 2018
@spongedu
Copy link
Contributor Author

spongedu commented Jul 31, 2018

#7196 deal with:

  • sql_select_limit
  • max_connect_errors
  • table_definition_cache
  • tmp_table_size
  • connect_timeout

@laidahe
Copy link
Contributor

laidahe commented Jul 31, 2018

Is there any other system variables need to add? @spongedu

@spongedu
Copy link
Contributor Author

@laidahe you can take a look at https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html and #7196 , and find the remaining system variables in sessionctx/variable/sysvar.go

@morgo
Copy link
Contributor

morgo commented Mar 25, 2022

I am going close this issue since we have better handling for this in system variables now.

There are still problems such as #28842 -- but we usually fix them as discovered, and for new system variables introduced we review the MinValue/MaxValue closely.

@morgo morgo closed this as completed Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

4 participants