executor: add diagnosis rule to check some metrics exceed thresholds #14801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs <crazycs520@gmail.com>
zimulala
reviewed
Feb 17, 2020
Signed-off-by: crazycs <crazycs520@gmail.com>
Deardrops
reviewed
Feb 17, 2020
lonng
reviewed
Feb 17, 2020
lonng
reviewed
Feb 17, 2020
lonng
reviewed
Feb 17, 2020
lonng
reviewed
Feb 17, 2020
Co-Authored-By: Maxwell <passagesfall@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
|
/rebuild |
lonng
reviewed
Feb 18, 2020
Signed-off-by: crazycs <crazycs520@gmail.com>
lonng
reviewed
Feb 18, 2020
Signed-off-by: crazycs <crazycs520@gmail.com>
|
/rebuild |
|
/rebuild |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@crazycs520 merge failed. |
|
/rebuild |
2 similar comments
|
/rebuild |
|
/rebuild |
This was referenced Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs crazycs520@gmail.com
What problem does this PR solve?
This PR adds a new diagnosis rule --
threshold-check, which is used to check some metrics threshold value, like tikv thread cpu usage. We will detect the following metrics tables in the current implementation:tikv_thread_cpuConsider the PR length, this PR only add some part checks of
threshold-checkrule, I will add more check in the next PR.What is changed and how it works?
Check List
Tests
Release note
threshold-checkwhich is used to check some metrics threshold value.