executor: add more diagnosis rule to check some metrics exceed thresholds #14843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olds Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
… into thresshold-check-2
lonng
reviewed
Feb 19, 2020
56 tasks
56 tasks
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Deardrops
reviewed
Feb 20, 2020
executor/inspection_result.go
Outdated
| } | ||
| for _, row := range rows { | ||
| actual := fmt.Sprintf("%.2f", row.GetFloat64(1)) | ||
| expect := "" |
There was a problem hiding this comment.
Suggested change
| expect := "" | |
| expected := "" |
Signed-off-by: crazycs <crazycs520@gmail.com>
Deardrops
added
status/LGT2
|
/run-all-tests |
crazycs520
added
the
status/can-merge
|
/run-all-tests |
|
@crazycs520 merge failed. |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs crazycs520@gmail.com
What problem does this PR solve?
This PR is the continuation of PR #14801.
This PR adds a more
threshold-checkrule, which is used to check some metrics threshold value, liketso duration,get token duration,storage-writeduration and so on. It will detect the following metrics tables in the current implementation:pd_tso_wait_durationtidb_get_token_durationtidb_load_schema_durationtikv_scheduler_command_durationtikv_handle_snapshot_durationtikv_storage_async_request_durationtikv_storage_async_request_durationtikv_engine_write_durationtikv_engine_max_get_durationtikv_engine_max_seek_durationtikv_scheduler_pending_commandstikv_block_index_cache_hittikv_block_filter_cache_hittikv_block_data_cache_hitWhat is changed and how it works?
Get the metric-data and compare with the threshold.
Check List
Tests