executor: do not log slow query for pessimistic write conflict retry (#15890) #16066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
sig/execution
|
LGTM |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15890 to release-3.1
What problem does this PR solve?
Problem Summary:
Slow Query is logged for each pessimistic select for update retry statement, which is confusing.
What is changed and how it works?
What's Changed:
Do not use
recordSet, execute directly.How it Works:
recordSetlog slow query onClose, remove it to avoid logging slow query.Related changes
Check List
Tests
Run a conflicting workload for a while and check that the slow-log file size is smaller compares to the master.