executor: do not log slow query for pessimistic write conflict retry #15890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
added
type/enhancement
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #15890 +/- ##
===============================================
- Coverage 80.4323% 80.426% -0.0063%
===============================================
Files 505 504 -1
Lines 135131 134853 -278
===============================================
- Hits 108689 108457 -232
+ Misses 17930 17898 -32
+ Partials 8512 8498 -14 |
|
/merge |
sre-bot
added
the
status/can-merge
lysu
added
status/LGT2
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #15932 |
|
cherry pick to release-4.0 in PR #15933 |
sre-bot
added a commit
that referenced
this pull request
Apr 1, 2020
coocood
pushed a commit
to coocood/tidb
that referenced
this pull request
Apr 1, 2020
|
/run-cherry-picker |
ngaut
pushed a commit
that referenced
this pull request
Apr 1, 2020
|
/run-cherry-picker |
4 similar comments
|
/run-cherry-picker |
|
/run-cherry-picker |
|
/run-cherry-picker |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 3, 2020
|
cherry pick to release-3.1 in PR #16066 |
sre-bot
added a commit
that referenced
this pull request
Apr 4, 2020
|
It seems that, not for sure, we failed to cherry-pick this commit to release-3.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @coocood PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Slow Query is logged for each pessimistic select for update retry statement, which is confusing.
What is changed and how it works?
What's Changed:
Do not use
recordSet, execute directly.How it Works:
recordSetlog slow query onClose, remove it to avoid logging slow query.Related changes
Check List
Tests
Run a conflicting workload for a while and check that the slow-log file size is smaller compares to the master.