server: let select for update could be recorded for slow log and statements (#16743) #16885
+53
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16743 to release-3.1
What problem does this PR solve?
Problem Summary:
The pessimistic
select for update
statements could not be logged as slow query, also other thingsRecordSet
.Close
will doWhat is changed and how it works?
Proposal: xxx
What's Changed:
Change the close function of
chunkRowRecordSet
How it Works:
Related changes
Check List
Tests
Start two sessions let the second select for update statement wait lock for sometime, the slow query should recorded like
Side effects
Release note