server: let select for update could be recorded for slow log and statements #16743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfzjywxk
added
type/bugfix
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #16743 +/- ##
================================================
- Coverage 80.3228% 80.3142% -0.0087%
================================================
Files 507 507
Lines 137220 137358 +138
================================================
+ Hits 110219 110318 +99
- Misses 18334 18367 +33
- Partials 8667 8673 +6 |
|
Was it introduced by #15890 ? |
coocood
reviewed
Apr 26, 2020
executor/adapter.go
Outdated
| @@ -437,6 +438,12 @@ func (c *chunkRowRecordSet) NewChunk() *chunk.Chunk { | |||
| } | |||
|
|
|||
| func (c *chunkRowRecordSet) Close() error { | |||
| c.execStmt.FinishExecuteStmt(c.execStmt.Ctx.GetSessionVars().TxnCtx.StartTS, true, false) | |||
There was a problem hiding this comment.
Can we extract the lines to a method in ExecStmt?
|
LGTM |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 28, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #16884 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 28, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #16885 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 28, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #16886 |
|
cherry pick to release-4.0 in PR #16897 |
|
cherry pick to release-3.1 in PR #16901 |
|
cherry pick to release-3.0 in PR #16903 |
sre-bot
pushed a commit
that referenced
this pull request
Apr 28, 2020
sre-bot
pushed a commit
that referenced
this pull request
Apr 28, 2020
sre-bot
pushed a commit
that referenced
this pull request
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
The pessimistic
select for updatestatements could not be logged as slow query, also other thingsRecordSet.Closewill doWhat is changed and how it works?
Proposal: xxx
What's Changed:
Change the close function of
chunkRowRecordSetHow it Works:
Related changes
Check List
Tests
Start two sessions let the second select for update statement wait lock for sometime, the slow query should recorded like
Side effects
Release note