Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/admin: support admin recover index on the partition table #17195

Merged
merged 11 commits into from
May 20, 2020

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented May 14, 2020

What problem does this PR solve?

Close #17343

Before this PR, admin recover index won't take effect on partition table.

What is changed and how it works?

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

  • Support admin recover index on the partition table.

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 added type/bugfix This PR fixes a bug. component/util labels May 14, 2020
@crazycs520 crazycs520 requested a review from a team as a code owner May 14, 2020 05:29
@ghost ghost requested review from wshwsh12 and removed request for a team May 14, 2020 05:29
@crazycs520
Copy link
Contributor Author

@tiancaiamao @zimulala PTAL

@github-actions github-actions bot added the sig/execution SIG execution label May 14, 2020
@crazycs520 crazycs520 added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label May 14, 2020
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label May 14, 2020
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #17195 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #17195   +/-   ##
===========================================
  Coverage   80.0005%   80.0005%           
===========================================
  Files           517        517           
  Lines        140504     140504           
===========================================
  Hits         112404     112404           
  Misses        19155      19155           
  Partials       8945       8945           

@tiancaiamao
Copy link
Contributor

PTAL @XuHuaiyu @imtbkcat

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2020
@XuHuaiyu
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 19, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 19, 2020

@crazycs520 merge failed.

@XuHuaiyu
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

@crazycs520 merge failed.

@tiancaiamao
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit 4078eb4 into pingcap:master May 20, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request May 20, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

cherry pick to release-3.0 in PR #17315

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request May 20, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

cherry pick to release-3.1 in PR #17316

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request May 20, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

cherry pick to release-4.0 in PR #17317

jebter pushed a commit that referenced this pull request May 21, 2020
… (#17317)

* cherry pick #17195 to release-4.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* fix test

Signed-off-by: crazycs520 <crazycs520@gmail.com>

Co-authored-by: crazycs <crazycs520@gmail.com>
@crazycs520 crazycs520 deleted the admin-recover-index branch May 26, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/util priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin recover index not work on the partition table
4 participants