Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/admin: support admin recover index on the partition table (#17195) #17315

Merged
merged 2 commits into from
May 26, 2020
Merged

util/admin: support admin recover index on the partition table (#17195) #17315

merged 2 commits into from
May 26, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 20, 2020

cherry-pick #17195 to release-3.0

What problem does this PR solve?

Before this PR, admin recover index won't take effect on partition table.

What is changed and how it works?

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

  • Support admin recover index on the partition table.

@crazycs520 @sre-bot
cherry pick pingcap#17195 to release-3.0
b55ccd9 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot sre-bot added sig/execution SIG execution component/util priority/release-blocker This issue blocks a release. Please solve it ASAP. type/3.0-cherry-pick labels May 20, 2020
@sre-bot sre-bot mentioned this pull request May 20, 2020
Merged
@sre-bot sre-bot added the type/bugfix This PR fixes a bug. label May 20, 2020
@sre-bot sre-bot requested review from wshwsh12 and XuHuaiyu May 20, 2020 09:12
@sre-bot sre-bot added this to the v3.0.15 milestone May 20, 2020
djshow832
djshow832 reviewed May 21, 2020
View reviewed changes
executor/admin.go Outdated Show resolved Hide resolved
@crazycs520
fix test
819ccb2 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
zimulala
zimulala reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label May 26, 2020
@crazycs520
Copy link
Contributor

/run-all-tests

@zimulala zimulala merged commit fbd6270 into pingcap:release-3.0 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@djshow832 djshow832 djshow832 left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@crazycs520 crazycs520

Labels
component/util priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.15
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @tiancaiamao @crazycs520 @zimulala @djshow832