*: fix update bug in cluster index #18045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Jun 16, 2020
executor/update_test.go
Outdated
|
|
||
| tk.MustExec("drop table if exists t") | ||
| tk.MustExec("create table t(a char(10) primary key, b char(10));") | ||
| tk.MustExec("insert into t values(\"a\", \"\");") |
There was a problem hiding this comment.
You can use single quote to make it more readable.
executor/update_test.go
Outdated
| tk.MustExec("drop table if exists t") | ||
| tk.MustExec("create table t(a char(10) primary key, b char(10));") | ||
| tk.MustExec("insert into t values(\"a\", \"\");") | ||
| tk.MustExec("update t set a=\"c\" where t.a=\"a\" and b=\"\";") |
There was a problem hiding this comment.
Need select and check the result?
| @@ -2827,7 +2827,7 @@ func (b *PlanBuilder) buildDataSource(ctx context.Context, tn *ast.TableName, as | |||
| IsHidden: col.Hidden, | |||
| } | |||
|
|
|||
| if tableInfo.PKIsHandle && mysql.HasPriKeyFlag(col.Flag) { | |||
| if col.IsPKHandleColumn(tableInfo) || col.IsCommonHandleColumn(tableInfo) { | |||
There was a problem hiding this comment.
There could be multiple handleCols if the table has a multi-column primary key.
Codecov Report
@@ Coverage Diff @@
## master #18045 +/- ##
================================================
- Coverage 80.1399% 79.4445% -0.6954%
================================================
Files 524 524
Lines 147356 142191 -5165
================================================
- Hits 118091 112963 -5128
+ Misses 20089 20073 -16
+ Partials 9176 9155 -21 |
|
LGTM |
|
/run-all-tests |
|
/run-integration-ddl-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #18043
Problem Summary:
What is changed and how it works?
Related changes
Check List
Tests
Side effects
Release note