*: fix bugs that creating index on clustered index table or table with the virtual generated column #18114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sig/sql-infra
tangenta
reviewed
Jun 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #18114 +/- ##
===========================================
Coverage 79.9567% 79.9567%
===========================================
Files 526 526
Lines 145535 145535
===========================================
Hits 116365 116365
Misses 20000 20000
Partials 9170 9170 |
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
…ster_virtual_index
wjhuang2016
force-pushed
the
fix_cluster_virtual_index
branch
from
7582e43
to
500ee76
Compare
|
/label LGT1 |
|
/unlabel LGT1 |
wjhuang2016
changed the title
coocood
reviewed
Jun 19, 2020
util/rowDecoder/decoder.go
Outdated
| return row, nil | ||
| } | ||
|
|
||
| pkCols := tables.TryGetCommonPkColumnIds(tbl) |
There was a problem hiding this comment.
The RowDecoder already has a table field, we show create pkCols in NewRowDecoder.
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
coocood
reviewed
Jun 19, 2020
util/rowDecoder/decoder.go
Outdated
| // DecodeAndEvalRowWithMap decodes a byte slice into datums and evaluates the generated column value. | ||
| func (rd *RowDecoder) DecodeAndEvalRowWithMap(ctx sessionctx.Context, handle kv.Handle, b []byte, decodeLoc, sysLoc *time.Location, row map[int64]types.Datum) (map[int64]types.Datum, error) { | ||
| func (rd *RowDecoder) DecodeAndEvalRowWithMap(ctx sessionctx.Context, handle kv.Handle, b []byte, decodeLoc, sysLoc *time.Location, row map[int64]types.Datum, tbl *model.TableInfo) (map[int64]types.Datum, error) { |
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
|
LGTM |
wjhuang2016
force-pushed
the
fix_cluster_virtual_index
branch
from
4ae9899
to
179b8f1
Compare
coocood
approved these changes
Jun 19, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/merge |
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18061
Problem Summary:
I wrongly remove the handle's decode logic in #18045.
Anyway, the previously handle's decode logic didn't consider common handle, it's not completely correct.
What is changed and how it works?
DecodeAndEvalRowWithMap()and implement the common handle part.decodeOldRowValToChunk(), point_get.goDecodeAndEvalRowWithMap(), do it inDecodeAndEvalRowWithMap().TryGetCommonPkColumnIdsandTryGetCommonPkColumns.Related changes
Check List
Tests
Side effects
Release note