store/tikv: fix bug strip keys cause primary key change during prewrite and commit #18258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
This bug is introduced in #14968
We use the first key in the mutations as the primary key, after
stripNoNeedCommitKeys
,the first key of the mutations may be striped and primary key change!
Prewrite and commit use the different primary key could lead to serious bug.
For example:
Part of the transaction is success and part of it fail, leads to data corruption.
This kind of log occures in the log:
What is changed and how it works?
What's Changed:
Specify the primary key in
initKeysAndMutations
.Choose the first non-"Delete your write" key as the primary key.
How it Works:
If
primary()
function find primaryKey is set in the commiter, it use the primaryKey instead of mutations[0].Related changes
Check List
Tests
Release note