-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: fix primary selection when delete-your-writes #18244
tikv: fix primary selection when delete-your-writes #18244
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18244 +/- ##
================================================
- Coverage 79.5531% 79.4408% -0.1123%
================================================
Files 535 535
Lines 144443 143907 -536
================================================
- Hits 114909 114321 -588
- Misses 20268 20319 +51
- Partials 9266 9267 +1 |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jackysp,Thanks for you review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bobotu,Thanks for you review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@coocood,Thanks for you review. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.0 in PR #18248 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.1 in PR #18249 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #18250 |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
prewrite
request #9127 introduce addition useless but sometime wrong DEL mutation for delete-your-writesso it will cause read/write inconsistent result when meet lock that point to a primary key has be insert/delete in own txn.
https://github.com/pingcap/tidb/pull/18244/files#diff-d11e207d2529a00e79d72b84ae5172caR722 will fail and read nothing to reproduce it in 2pc test case level.
What is changed and how it works?
What's Changed, How it Works:
choose first key didn't be delete by itself as primary key.
Related changes
Check List
Tests
Side effects
Release note
This change is