tikv: choose right primary only contains SelectForUpdate & Delete-your-writes #18264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Delete-your-writes
lysu
added
sig/transaction
Codecov Report
@@ Coverage Diff @@
## master #18264 +/- ##
===========================================
Coverage 79.4461% 79.4461%
===========================================
Files 535 535
Lines 144129 144129
===========================================
Hits 114505 114505
Misses 20354 20354
Partials 9270 9270 |
|
@jackysp,Thanks for you review. |
|
LGTM |
|
@coocood,Thanks for you review. |
jackysp
approved these changes
Jun 30, 2020
|
@jackysp, Thanks for your review, however we are sorry that your vote won't be count. You already give a LGTM to this PR |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@lysu merge failed. |
|
/merge |
|
/run-all-tests |
|
@lysu merge failed. |
|
/merge |
|
/run-all-tests |
|
@lysu merge failed. |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 30, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18291 |
jackysp
pushed a commit
that referenced
this pull request
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
questions found follow by #18244
add test case that:
https://github.com/pingcap/tidb/pull/18264/files#diff-d11e207d2529a00e79d72b84ae5172caR800 will fail
What is changed and how it works?
Proposal: xxx
What's Changed, How it Works:
Related changes
Check List
Tests
Side effects
Release note
This change is