gc_worker: resolve locks on offline stores #18383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
|
BTW, I think we need cherry-pick it to release-3.0/3.1 too because offline stores are skipped during destroying ranges. It's possible an offline store becomes up if someone deletes a wrong store and reverts the operation. @MyonKeminta |
Codecov Report
@@ Coverage Diff @@
## master #18383 +/- ##
===========================================
Coverage 79.4581% 79.4581%
===========================================
Files 541 541
Lines 146457 146457
===========================================
Hits 116372 116372
Misses 20787 20787
Partials 9298 9298 |
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
…95/tidb into gc/scan-offline-store
|
@MyonKeminta PTAL |
MyonKeminta
previously approved these changes
Jul 14, 2020
| @@ -459,7 +459,7 @@ func (w *GCWorker) checkGCInterval(now time.Time) (bool, error) { | |||
| } | |||
|
|
|||
| // validateGCLiftTime checks whether life time is small than min gc life time. | |||
| func (w *GCWorker) validateGCLiftTime(lifeTime time.Duration) (time.Duration, error) { | |||
cfzjywxk
reviewed
Jul 14, 2020
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
cfzjywxk
approved these changes
Jul 14, 2020
ti-srebot
approved these changes
Jul 14, 2020
cfzjywxk
added
the
status/can-merge
|
/run-all-tests |
|
@youjiali1995 merge failed. |
|
/merge |
|
/run-all-tests |
|
@youjiali1995 merge failed. |
|
/run-integration-copr-test |
|
/merge |
|
/run-all-tests |
|
@youjiali1995 merge failed. |
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 14, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18550 |
bb7133
pushed a commit
that referenced
this pull request
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Issue Number: close #18338
Problem Summary:
Green GC should scan locks on offline stores.
What is changed and how it works?
What's Changed:
Only skip tombstone stores.
Related changes
Check List
Tests
Release note