Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc_worker: resolve locks on offline stores (#18383) #18550

Merged
merged 3 commits into from
Jul 15, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18383 to release-4.0


Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What problem does this PR solve?

Issue Number: close #18338
Problem Summary:
Green GC should scan locks on offline stores.

What is changed and how it works?

What's Changed:
Only skip tombstone stores.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit tes

Release note

  • Fix the issue that green GC doesn't scan locks on offline stores which may cause data incompleteness.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@youjiali1995
Copy link
Contributor

/run-unit-test

@cfzjywxk cfzjywxk added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Jul 15, 2020
@cfzjywxk
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2020
@sticnarf
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 18554

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@winoros
Copy link
Member

winoros commented Jul 15, 2020

/run-integration-copr-test

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 15, 2020
@bb7133 bb7133 merged commit cdf2017 into pingcap:release-4.0 Jul 15, 2020
@winoros winoros deleted the release-4.0-2024e44636f2 branch July 15, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/GC priority/release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants