Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDL: check table-level check constraint when create table #20202

Merged
merged 3 commits into from
Sep 25, 2020
Merged

DDL: check table-level check constraint when create table #20202

merged 3 commits into from
Sep 25, 2020

Conversation

AilinKid
Copy link
Contributor

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #20201

What is changed and how it works?

What's Changed:
check table-level check constraint when creating a table

Check List

Tests

  • Unit test
  • Integration test

Release note

  • DDL: check table-level check constraint when creating a table

@AilinKid
.
a2ca0b7 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid AilinKid added type/bugfix This PR fixes a bug. sig/sql-infra SIG: SQL Infra component/ddl labels Sep 24, 2020
@AilinKid AilinKid self-assigned this Sep 24, 2020
@AilinKid
Copy link
Contributor Author

/run-all-tests

djshow832
djshow832 reviewed Sep 25, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2020
tangenta
tangenta reviewed Sep 25, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 25, 2020
@djshow832
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 25, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 0843f32 into pingcap:master Sep 25, 2020
@AilinKid
Copy link
Contributor Author

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 25, 2020
@AilinKid @ti-srebot
cherry pick pingcap#20202 to release-4.0
a77b53f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 25, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20214

ti-srebot added a commit that referenced this pull request Oct 3, 2020
@ti-srebot
DDL: check table-level check constraint when create table (#20202) (#…
6efcee0 
…20214)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: AilinKid <314806019@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@djshow832 djshow832 djshow832 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@bb7133 bb7133 Awaiting requested review from bb7133

@zimulala zimulala Awaiting requested review from zimulala

Assignees

@AilinKid AilinKid

Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ddl: create table occurs unamed index without column.
4 participants
@AilinKid @djshow832 @ti-srebot @tangenta