Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDL: check table-level check constraint when create table (#20202) #20214

Merged
merged 5 commits into from
Oct 3, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20202 to release-4.0


Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #20201

What is changed and how it works?

What's Changed:
check table-level check constraint when creating a table

Check List

Tests

  • Unit test
  • Integration test

Release note

  • DDL: check table-level check constraint when creating a table

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@bb7133
Copy link
Member

bb7133 commented Sep 27, 2020

Please resolve the conflicts @AilinKid

AilinKid and others added 2 commits September 28, 2020 18:27
.
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid AilinKid requested review from djshow832 and removed request for djshow832 September 28, 2020 10:29
@AilinKid
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 28, 2020
@AilinKid
Copy link
Contributor

/run-tics-test

2 similar comments
@AilinKid
Copy link
Contributor

/run-tics-test

@AilinKid
Copy link
Contributor

/run-tics-test

@AilinKid AilinKid removed this from the v4.0.8 milestone Sep 28, 2020
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 28, 2020
@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @zz-jason, you don't have permission to trigger auto merge event on this branch.

@AilinKid
Copy link
Contributor

/run-tics-test

1 similar comment
@AilinKid
Copy link
Contributor

/run-tics-test

@AilinKid
Copy link
Contributor

/build

@AilinKid
Copy link
Contributor

/run-all-tests

@AilinKid
Copy link
Contributor

/run-all-tests

@AilinKid
Copy link
Contributor

/run-tics-test

1 similar comment
@AilinKid
Copy link
Contributor

/run-tics-test

@AilinKid
Copy link
Contributor

/merge

@AilinKid
Copy link
Contributor

/run-tics-test

@zz-jason
Copy link
Member

zz-jason commented Oct 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 3, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20297
  • 20293
  • 20155
  • 20074
  • 20252
  • 20240
  • 20248
  • 20249
  • 20216
  • 20154
  • 19944
  • 20210
  • 20205

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 6efcee0 into pingcap:release-4.0 Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants