expression: fix overflow error when convert bit to int64 #20266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
requested review from
wshwsh12,
SunRunAway and
XuHuaiyu
and removed request for
a team
|
/run-all-tests |
|
/run-all-tests |
|
/run-unit-test |
|
/run-unit-test |
ti-srebot
approved these changes
Sep 30, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 30, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.0 in PR #20311 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 30, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #20312 |
XuHuaiyu
pushed a commit
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #20059
What is changed and how it works?
How it Works: do not check overflow but only set int64(uint64) for bit.
Related changes
Check List
Tests
Release note