-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix OverFlowErr when convert bit to int64 (#20266) #20312
expression: fix OverFlowErr when convert bit to int64 (#20266) #20312
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wshwsh12, Thanks for your review, however we are sorry that your vote won't be count. |
LGTM |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@ti-srebot merge failed. |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
cherry-pick #20266 to release-4.0
What problem does this PR solve?
Issue Number: close #20059
What is changed and how it works?
How it Works: do not check overflow but only set int64(uint64) for bit.
Related changes
Check List
Tests
Release note