Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert: fix the auto id retry won't cast the datum to origin type #29997

Merged
merged 8 commits into from
Nov 22, 2021

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Nov 22, 2021

Signed-off-by: ailinkid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #29892

What is changed and how it works?

  • Fix the session retry won't cast the datum to the origin type under insert into select from
  • In the original issue Retrying transaction with a double type auto-increment column leads to data error #29892, the session1 commit should fail with duplicate entry while it doesn't. Because the session2's inserted key is built from (double)146576795, while the session1's retried key is built from (int64)146576795 without cast. Different type contributing the comparison failure.

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
same as what has been described in the issue

Release note

None

Signed-off-by: ailinkid <314806019@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2021
Signed-off-by: ailinkid <314806019@qq.com>
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0ddc4ac

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2021
@ti-chi-bot ti-chi-bot merged commit 51f53f3 into pingcap:master Nov 22, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 22, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #30019

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 22, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #30020

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 22, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #30021

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 22, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #30022

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 22, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #30023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrying transaction with a double type auto-increment column leads to data error
5 participants