-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
insert: fix the auto id retry won't cast the datum to origin type (#29997) #30019
insert: fix the auto id retry won't cast the datum to origin type (#29997) #30019
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@AilinKid you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 697ab26
|
cherry-pick #29997 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30019
After apply modifications, you can push your change to this PR via:
Signed-off-by: ailinkid 314806019@qq.com
What problem does this PR solve?
Issue Number: close #29892
What is changed and how it works?
insert into select from
duplicate entry
while it doesn't. Because the session2's inserted key is built from (double)146576795, while the session1's retried key is built from (int64)146576795 without cast. Different type contributing the comparison failure.Tests
Release note