Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix panic when using wrong globalStats.Indices key #35424

Merged
merged 6 commits into from
Jun 20, 2022
Merged

statistics: fix panic when using wrong globalStats.Indices key #35424

merged 6 commits into from
Jun 20, 2022

Conversation

lilinghai
Copy link
Contributor

Signed-off-by: lilinghai lilinghai@pingcap.com

What problem does this PR solve?

Issue Number: close #35421

Problem Summary:
Before the fix, The idx in the expressionfor idx := range tblInfo.Indices start from 0, and the expressionglobalStats.Indices[idx] will get nil. We should use model.IndexInfo.ID as the key to access the content of globalStats.Indices.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lilinghai
statistics: fix panic when using wrong globalStats.Indices key
0a322a0 
Signed-off-by: lilinghai <lilinghai@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • chrysan
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Jun 16, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 16, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 16, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2474cdafbc7ef0c44db2cfa16159a3732fccedb3

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels Jun 16, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 20, 2022
@lilinghai
Copy link
Contributor Author

/run-mysql-test

@lilinghai
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@lilinghai: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lilinghai
Copy link
Contributor Author

/run-build

@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d536f06

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 20, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 2a45f21 into pingcap:master Jun 20, 2022
@ti-srebot ti-srebot mentioned this pull request Jun 20, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 20, 2022
@lilinghai @ti-srebot
cherry pick pingcap#35424 to release-5.1
9ee9412 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #35539

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 20, 2022
@lilinghai @ti-srebot
cherry pick pingcap#35424 to release-5.2
e509c4f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 20, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #35540

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 20, 2022
@lilinghai @ti-srebot
cherry pick pingcap#35424 to release-5.3
c55f07e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 20, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #35541

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 20, 2022
@lilinghai @ti-srebot
cherry pick pingcap#35424 to release-5.4
9fb72a2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 20, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #35542

@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 failed

@ti-srebot ti-srebot mentioned this pull request Jun 20, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 20, 2022
@lilinghai @ti-srebot
cherry pick pingcap#35424 to release-6.1
8947f8c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #35543

morgo added a commit to morgo/tidb that referenced this pull request Jun 28, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into kill-ddl
afde8a8 
* upstream/master:
  sessionctx: support encoding and decoding session variables (pingcap#35531)
  planner: add batch_point_get access object (pingcap#35230)
  sessionctx: set skipInit false for TiDBOptProjectionPushDown and TiDBOptAggPushDown (pingcap#35491)
  *: add support for disabling noop variables (pingcap#35496)
  lightning: add store write limiter (pingcap#35193)
  expression: avoid padding 0 when implicitly cast to binary (pingcap#35053)
  types: fix creating partition tables fail in ANSI_QUOTES mode (pingcap#35379)
  executor: add the missed runtime stats when the index merge partial task returns 0 row (pingcap#35297)
  statistics: batch insert topn and bucket when saving table stats (pingcap#35326)
  parser: Add support for INTERVAL expr unit + expr (pingcap#30253) (pingcap#35390)
  config: add missing nodelay example (pingcap#35255)
  *: Introduce `OptimisticTxnContextProvider` for optimistic txn (pingcap#35131)
  statistics: fix panic when using wrong globalStats.Indices key (pingcap#35424)
  *: fix store token is up to the limit in test (pingcap#35374)
  *: enable more flaky and update bazel config (pingcap#35500)
  ddl: expose getPrimaryKey() as a public method of model.TableInfo (pingcap#35512)
  expression, util: add `KeyWithoutTrimRightSpace` for collator (pingcap#35475)
  infoschema: try on each PD member until one succeeds or all fail (pingcap#35285)
@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Nov 21, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Nov 25, 2022
@ti-srebot
statistics: fix panic when using wrong globalStats.Indices key (#35424)…
ed8dda9 
… (#35543)

close #35421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysan chrysan chrysan approved these changes

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The updateStatsWorker goroutine panic with invalid memory addr or nil pointer ref
8 participants
@lilinghai @ti-chi-bot @sre-bot @XuHuaiyu @hawkingrei @ti-srebot @chrysan @xuyifangreeneyes