Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics/grafana: bring back the plan cache miss panel #36081

Merged
merged 3 commits into from
Jul 13, 2022
Merged

metrics/grafana: bring back the plan cache miss panel #36081

merged 3 commits into from
Jul 13, 2022

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #36079

Problem Summary:

What is changed and how it works?

Fix tidb.json for grafana, introduced by #34718

I think it's when resolving conflict that I made this mistake https://github.com/pingcap/tidb/pull/34718/files#diff-b0f0d6ff06d9a9443e2a547c21b99c2e7cdaa4a91d99717cd9eef53cef1c0953L6100

There are two "Query Using Plan Cache OPS"
and the "Plan Cache Miss OPS" is removed mistakenly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
tiup playground

Open http://127.0.0.1:3000/
Then load the new tidb.json, see it's now corrected.

image

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2022
@tiancaiamao tiancaiamao requested a review from qw4990 July 11, 2022 05:36
@tiancaiamao tiancaiamao marked this pull request as ready for review July 11, 2022 05:36
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 11, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d170dc7c47928edd030b0a2efca2109156942aed

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2022
@xhebox
Copy link
Contributor

xhebox commented Jul 13, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 71d8b21

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2022
@ti-chi-bot ti-chi-bot merged commit 523da29 into pingcap:master Jul 13, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 13, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 35, total 36 23 min Existing failure
idc-jenkins-ci-tidb/common-test ✅ all 12 tests passed 21 min Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 9 min 15 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 8 min 53 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 11 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 35 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 15 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 40 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

joycse06 added a commit to joycse06/tidb that referenced this pull request Jul 13, 2022
@joycse06
Merge branch 'master' into add-sql-require-primary-key
0e25f45 
* master: (27 commits)
  executor: parallel cancel mpp query (pingcap#36161)
  store/copr: adjust the cop cache admission process time for paging (pingcap#36157)
  log-backup: get can restored global-checkpoint-ts when support v3 checkpoint advance (pingcap#36197)
  executor: optimize cursor read point get by reading through pessimistic lock cache (pingcap#36149)
  *: add tidb_min_paging_size system variable (pingcap#36107)
  planner: handle the expected row count for pushed-down selection in mpp (pingcap#36195)
  *: support show ddl jobs for sub-jobs (pingcap#36168)
  table-filter: optimize table pattern message and unit tests (pingcap#36160)
  domain: fix unstable test TestAbnormalSessionPool (pingcap#36154)
  executor: check the error returned by `handleNoDelay` (pingcap#36105)
  log-backup: fix checkpoint display (pingcap#36166)
  store/mockstore/unistore: fix several issues of coprocessor paging in unistore (pingcap#36147)
  test: refactor restart test (pingcap#36174)
  ddl: support rename index and columns for multi-schema change (pingcap#36148)
  test: remove meaningless test and update bazel (pingcap#36136)
  planner: Reduce verbosity of logging unknown system variables (pingcap#36013)
  metrics/grafana: bring back the plan cache miss panel (pingcap#36081)
  ddl: implement table granularity DDL for SchemaTracker (pingcap#36077)
  *: bazel use jdk 17 (pingcap#36070)
  telemetry: add reviewer rule (pingcap#36084)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox xhebox approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There are two "Query Using Plan Cache OPS" panel
5 participants
@tiancaiamao @ti-chi-bot @sre-bot @xhebox @hawkingrei