Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support show ddl jobs for sub-jobs #36168

Merged
merged 14 commits into from
Jul 13, 2022

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jul 13, 2022

What problem does this PR solve?

Issue Number: ref #14766

Problem Summary:

This PR supports ADMIN SHOW DDL JOBS for multi-schema change.

create table t (a int, b int, c int, index i1(c), index i2(c));
insert into t values (1, 2, 3);
alter table t add column d int default 4, add index i3(c), drop column a, drop column if exists z, add column if not exists e int default 5, drop index i2, add column f int default 6, drop column b, drop index i1, add column if not exists c int;

admin show ddl jobs 1;
+--------+---------+------------+---------------------------------+--------------+-----------+----------+-----------+---------------------+---------------------+---------------------+--------+
| JOB_ID | DB_NAME | TABLE_NAME | JOB_TYPE                        | SCHEMA_STATE | SCHEMA_ID | TABLE_ID | ROW_COUNT | CREATE_TIME         | START_TIME          | END_TIME            | STATE  |
+--------+---------+------------+---------------------------------+--------------+-----------+----------+-----------+---------------------+---------------------+---------------------+--------+
|    110 | test    | t          | alter table multi-schema change | none         |         1 |      108 |         0 | 2022-07-13 11:48:56 | 2022-07-13 11:48:56 | 2022-07-13 11:48:56 | synced |
|    110 | test    | t          | add column /* subjob */         | public       |         1 |      108 |         0 | NULL                | NULL                | NULL                | done   |
|    110 | test    | t          | add index /* subjob */          | public       |         1 |      108 |         1 | NULL                | NULL                | NULL                | done   |
|    110 | test    | t          | drop column /* subjob */        | none         |         1 |      108 |         0 | NULL                | NULL                | NULL                | done   |
|    110 | test    | t          | add column /* subjob */         | public       |         1 |      108 |         0 | NULL                | NULL                | NULL                | done   |
|    110 | test    | t          | drop index /* subjob */         | none         |         1 |      108 |         0 | NULL                | NULL                | NULL                | done   |
|    110 | test    | t          | add column /* subjob */         | public       |         1 |      108 |         0 | NULL                | NULL                | NULL                | done   |
|    110 | test    | t          | drop column /* subjob */        | none         |         1 |      108 |         0 | NULL                | NULL                | NULL                | done   |
|    110 | test    | t          | drop index /* subjob */         | none         |         1 |      108 |         0 | NULL                | NULL                | NULL                | done   |
+--------+---------+------------+---------------------------------+--------------+-----------+----------+-----------+---------------------+---------------------+---------------------+--------+
9 rows in set (0.01 sec)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 13, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2022
@xhebox
Copy link
Contributor

xhebox commented Jul 13, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ac4f13

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 13, 2022

@hawkingrei
Copy link
Member

/run-mysql-test

@hawkingrei
Copy link
Member

/run-build

@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@tangenta: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 2f934d6 into pingcap:master Jul 13, 2022
joycse06 added a commit to joycse06/tidb that referenced this pull request Jul 13, 2022
* master: (27 commits)
  executor: parallel cancel mpp query (pingcap#36161)
  store/copr: adjust the cop cache admission process time for paging (pingcap#36157)
  log-backup: get can restored global-checkpoint-ts when support v3 checkpoint advance (pingcap#36197)
  executor: optimize cursor read point get by reading through pessimistic lock cache (pingcap#36149)
  *: add tidb_min_paging_size system variable (pingcap#36107)
  planner: handle the expected row count for pushed-down selection in mpp (pingcap#36195)
  *: support show ddl jobs for sub-jobs (pingcap#36168)
  table-filter: optimize table pattern message and unit tests (pingcap#36160)
  domain: fix unstable test TestAbnormalSessionPool (pingcap#36154)
  executor: check the error returned by `handleNoDelay` (pingcap#36105)
  log-backup: fix checkpoint display (pingcap#36166)
  store/mockstore/unistore: fix several issues of coprocessor paging in unistore (pingcap#36147)
  test: refactor restart test (pingcap#36174)
  ddl: support rename index and columns for multi-schema change (pingcap#36148)
  test: remove meaningless test and update bazel (pingcap#36136)
  planner: Reduce verbosity of logging unknown system variables (pingcap#36013)
  metrics/grafana: bring back the plan cache miss panel (pingcap#36081)
  ddl: implement table granularity DDL for SchemaTracker (pingcap#36077)
  *: bazel use jdk 17 (pingcap#36070)
  telemetry: add reviewer rule (pingcap#36084)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants