Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: add retryable error on checksum #37691

Merged
merged 4 commits into from
Sep 8, 2022
Merged

lightning: add retryable error on checksum #37691

merged 4 commits into from
Sep 8, 2022

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Sep 7, 2022

What problem does this PR solve?

Issue Number: close #37690

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@D3Hunter D3Hunter added the component/lightning This issue is related to Lightning of TiDB. label Sep 7, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • niubell

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 7, 2022

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 7, 2022

/cc @buchuitoudegou @gozssky @dsdashun

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 7, 2022

/cc @lance6716

niubell
niubell approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@niubell niubell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 7, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 8, 2022

ci pass
https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/13187/pipeline

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 33b5d07

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 8, 2022
@ti-chi-bot ti-chi-bot merged commit ec9e43e into pingcap:master Sep 8, 2022
@ti-srebot ti-srebot mentioned this pull request Sep 8, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 8, 2022
@D3Hunter @ti-srebot
cherry pick pingcap#37691 to release-6.1
47bb7e3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #37702

@D3Hunter D3Hunter deleted the retry-checksum-error branch September 8, 2022 02:58
@sre-bot
Copy link
Contributor

sre-bot commented Sep 8, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 16, total 17 16 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 9, total 11 13 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 32 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 25 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 31 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 0 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 11 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 13 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 0 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Sep 8, 2022
@ti-srebot
lightning: add retryable error on checksum (#37691) (#37702)
101368f 
close #37690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niubell niubell niubell approved these changes

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

@dsdashun dsdashun Awaiting requested review from dsdashun

@sleepymole sleepymole Awaiting requested review from sleepymole

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning: add retryable error on checksum
6 participants
@D3Hunter @ti-chi-bot @ti-srebot @sre-bot @niubell @buchuitoudegou