Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: add retryable error on checksum (#37691) #37702

Merged
merged 1 commit into from
Sep 8, 2022
Merged

lightning: add retryable error on checksum (#37691) #37702

merged 1 commit into from
Sep 8, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 8, 2022 •
edited
Loading

cherry-pick #37691 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/37702

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/37702:release-6.1-ec9e43ed7e5a

What problem does this PR solve?

Issue Number: close #37690

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@D3Hunter @ti-srebot
cherry pick pingcap#37691 to release-6.1
47bb7e3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • dsdashun
  • niubell

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 8, 2022
@ti-srebot ti-srebot mentioned this pull request Sep 8, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 8, 2022
@ti-srebot ti-srebot added component/lightning This issue is related to Lightning of TiDB. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.1-cherry-pick labels Sep 8, 2022
@ti-srebot ti-srebot added this to the v6.1.1 milestone Sep 8, 2022
@ti-srebot
Copy link
Contributor Author

@D3Hunter you're already a collaborator in bot's repo.

@D3Hunter
Copy link
Contributor

D3Hunter commented Sep 8, 2022

/run-integration-br-test

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 8, 2022
niubell
niubell approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@niubell niubell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2022
dsdashun
dsdashun approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@dsdashun dsdashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 8, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 47bb7e3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 8, 2022
@D3Hunter
Copy link
Contributor

D3Hunter commented Sep 8, 2022

ci pass
https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/13193/pipeline

@D3Hunter
Copy link
Contributor

D3Hunter commented Sep 8, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 101368f into pingcap:release-6.1 Sep 8, 2022
@D3Hunter D3Hunter deleted the release-6.1-ec9e43ed7e5a branch September 8, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsdashun dsdashun dsdashun approved these changes

@niubell niubell niubell approved these changes

@buchuitoudegou buchuitoudegou Awaiting requested review from buchuitoudegou

@sleepymole sleepymole Awaiting requested review from sleepymole

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees

@D3Hunter D3Hunter

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.1-cherry-pick
Projects
None yet
Milestone
v6.1.1
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @D3Hunter @hawkingrei @dsdashun @niubell @VelocityLight