Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix backup client (#41295) #41304

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 11, 2023

This is an automated cherry-pick of #41295

Signed-off-by: Leavrth jianjun.liao@outlook.com

What problem does this PR solve?

Issue Number: ref #40404 #40898

Problem Summary:

  1. We need to use autoIDAccess.SequenceValue().Get() instead of autoIDAccess.SequenceCycle().Get().
    refer to

    tidb/meta/autoid/autoid.go

    Lines 1162 to 1175 in 48bc046

    func (alloc *allocator) getIDAccessor(txn kv.Transaction) meta.AutoIDAccessor {
    acc := meta.NewMeta(txn).GetAutoIDAccessors(alloc.dbID, alloc.tbID)
    switch alloc.allocType {
    case RowIDAllocType:
    return acc.RowID()
    case AutoIncrementType:
    return acc.IncrementID(alloc.tbVersion)
    case AutoRandomType:
    return acc.RandomID()
    case SequenceType:
    return acc.SequenceValue()
    }
    return nil
    }
  2. fix condition when fetch replica label

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 11, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2023
12 tasks
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.6 labels Feb 11, 2023
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 11, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 11, 2023
@wuhuizuo
Copy link
Contributor

/retitle br: fix backup client (#41295)

@ti-chi-bot ti-chi-bot changed the title br: fix backup ci (#41295) br: fix backup client (#41295) Feb 11, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 12, 2023
@joccau
Copy link
Member

joccau commented Feb 12, 2023

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 11bbfad

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 12, 2023
@ti-chi-bot ti-chi-bot merged commit eed05a5 into pingcap:release-6.6 Feb 12, 2023
iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants