Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: fix backup client (#41295) #41304

Merged
merged 2 commits into from
Feb 12, 2023
Merged

br: fix backup client (#41295) #41304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
191319a
fix sequence id alloc when backup
Leavrth Feb 11, 2023
11bbfad
fix replica read label fetch
Leavrth Feb 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions br/pkg/backup/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ func BuildBackupRangeAndSchema(
var globalAutoID int64
switch {
case tableInfo.IsSequence():
globalAutoID, err = autoIDAccess.SequenceCycle().Get()
globalAutoID, err = autoIDAccess.SequenceValue().Get()
case tableInfo.IsView() || !utils.NeedAutoID(tableInfo):
// no auto ID for views or table without either rowID nor auto_increment ID.
default:
Expand Down Expand Up @@ -841,7 +841,7 @@ func (bc *Client) BackupRange(
} else {
for _, store := range allStores {
for _, label := range store.Labels {
if val, ok := replicaReadLabel[label.Key]; !ok && val == label.Value {
if val, ok := replicaReadLabel[label.Key]; ok && val == label.Value {
targetStores = append(targetStores, store) // send backup push down request to stores that match replica read label
targetStoreIds[store.GetId()] = struct{}{} // record store id for fine grained backup
}
Expand Down