Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/copr: fix missting Request.TxnScope (#43367) #43553

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 5, 2023

This is an automated cherry-pick of #43367

Ref #43481

What problem does this PR solve?

Issue Number: close #43365

Problem Summary:

What is changed and how it works?

Fix missing Request.TxnScope so the global stale-read optimization will take effect.

Seems there is no place to add a test for handling request inside coprocessor, the code change is really simple and safe.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

store/copr: fix missing `Request.TxnScope` so the global stale-read optimization will take effect.

Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 5, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 5, 2023
@ti-chi-bot ti-chi-bot added type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels May 5, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 5, 2023
@ti-chi-bot ti-chi-bot self-assigned this May 5, 2023
@you06 you06 added type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. and removed type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels May 5, 2023
@you06 you06 changed the title store/copr: fix missting Request.TxnScope (#43367) (#43374) store/copr: fix missting Request.TxnScope (#43367) May 5, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2023
@cfzjywxk cfzjywxk requested a review from zyguan May 6, 2023 04:01
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 20, 2023
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 9d3b66a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit 443f5ce into pingcap:release-6.5 May 21, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels May 29, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 29, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Sep 1, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants