Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix flaky test TestStoreRemoved #52834

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Apr 23, 2024

What problem does this PR solve?

Issue Number: close #52791, close #52792

Problem Summary:
When dropping a subscription manager, the pending events will be dropped. So the test case will fail.

What changed and how does it work?

Wait until it seems there isn't new events.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
> go test --count=100 -run '^TestSomeOfStoreUnsupported|TestStoreRemoved$' github.com/pingcap/tidb/br/pkg/streamhelper
ok      github.com/pingcap/tidb/br/pkg/streamhelper     40.463s
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: hillium <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2024
Copy link

tiprow bot commented Apr 23, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2024
Signed-off-by: hillium <yu745514916@live.com>
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #52834 (524355f) into master (65d4aea) will increase coverage by 2.6707%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52834        +/-   ##
================================================
+ Coverage   72.3680%   75.0387%   +2.6707%     
================================================
  Files          1474       1477         +3     
  Lines        427589     430532      +2943     
================================================
+ Hits         309438     323066     +13628     
+ Misses        98921      87187     -11734     
- Partials      19230      20279      +1049     
Flag Coverage Δ
integration 50.3543% <ø> (?)
unit 71.1879% <ø> (-0.0722%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 61.0829% <ø> (+19.8736%) ⬆️

Copy link

ti-chi-bot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 23, 2024
Copy link

ti-chi-bot bot commented Apr 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-23 06:05:45.624680035 +0000 UTC m=+67502.364582940: ☑️ agreed by Leavrth.
  • 2024-04-23 06:31:02.951753746 +0000 UTC m=+69019.691656658: ☑️ agreed by hawkingrei.

Copy link

tiprow bot commented Apr 23, 2024

@YuJuncen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 36e67e9 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: hillium <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot merged commit 36b738d into pingcap:master Apr 23, 2024
22 checks passed
YuJuncen added a commit to ti-chi-bot/tidb that referenced this pull request Jun 6, 2024
@YuJuncen
Copy link
Contributor Author

/run-cherry-picker

@YuJuncen YuJuncen added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 11, 2024
@YuJuncen
Copy link
Contributor Author

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #54572.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 11, 2024
YuJuncen added a commit to ti-chi-bot/tidb that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestSomeOfStoreUnsupported flaky test TestStoreRemoved
4 participants