-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix flaky test TestStoreRemoved
(#52834)
#54572
br: fix flaky test TestStoreRemoved
(#52834)
#54572
Conversation
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #54572 +/- ##
================================================
Coverage ? 71.9854%
================================================
Files ? 1412
Lines ? 410940
Branches ? 0
================================================
Hits ? 295817
Misses ? 95228
Partials ? 19895
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #52834
What problem does this PR solve?
Issue Number: close #52791, close #52792
Problem Summary:
When dropping a subscription manager, the pending events will be dropped. So the test case will fail.
What changed and how does it work?
Wait until it seems there isn't new events.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.