Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix flaky test TestStoreRemoved (#52834) #54572

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52834

What problem does this PR solve?

Issue Number: close #52791, close #52792

Problem Summary:
When dropping a subscription manager, the pending events will be dropped. So the test case will fail.

What changed and how does it work?

Wait until it seems there isn't new events.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
> go test --count=100 -run '^TestSomeOfStoreUnsupported|TestStoreRemoved$' github.com/pingcap/tidb/br/pkg/streamhelper
ok      github.com/pingcap/tidb/br/pkg/streamhelper     40.463s
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jul 11, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 11, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 11, 2024
Copy link

ti-chi-bot bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 11, 2024
Copy link

ti-chi-bot bot commented Jul 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-11 07:31:33.472299445 +0000 UTC m=+515590.707533558: ☑️ agreed by YuJuncen.
  • 2024-07-11 07:33:33.174469283 +0000 UTC m=+515710.409703398: ☑️ agreed by 3pointer.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@1ad607b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #54572   +/-   ##
================================================
  Coverage               ?   71.9854%           
================================================
  Files                  ?       1412           
  Lines                  ?     410940           
  Branches               ?          0           
================================================
  Hits                   ?     295817           
  Misses                 ?      95228           
  Partials               ?      19895           
Flag Coverage Δ
unit 71.9854% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4554% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit b32b212 into pingcap:release-7.5 Jul 11, 2024
22 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants