* : Remove binlog related codes #55955

Benjamin2037 · 2024-09-09T09:10:10Z

What problem does this PR solve?

Remove TiDB-binlog related code.

Issue Number: close #55949

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test

Only remove code.

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

TiDB-Binlog related code has been deleted, since TiDB-Binlog has been deprecated.

tiprow · 2024-09-09T09:10:25Z

Hi @Benjamin2037. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Benjamin2037 · 2024-09-09T13:39:35Z

/retest

tiprow · 2024-09-09T13:39:58Z

@Benjamin2037: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-09-10T01:13:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.8869%. Comparing base (66d8cdc) to head (6413d19).
Report is 5 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #55955         +/-   ##
=================================================
- Coverage   72.9612%   56.8869%   -16.0744%     
=================================================
  Files          1611       1758        +147     
  Lines        447632     630345     +182713     
=================================================
+ Hits         326598     358584      +31986     
- Misses       101001     247167     +146166     
- Partials      20033      24594       +4561

Flag	Coverage Δ
integration	`39.4316% <100.0000%> (?)`
unit	`72.5824% <100.0000%> (+0.5420%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9567% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`63.2709% <ø> (+17.3947%)`	⬆️

Benjamin2037 · 2024-09-11T01:04:49Z

/retest

tiprow · 2024-09-11T01:05:11Z

@Benjamin2037: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Benjamin2037 · 2024-09-11T02:39:01Z

It seems that we also need a PR to modify some mysql test cases. Form mysql test:

time="2024-09-11T10:10:03+08:00" level=error msg="run test [index_merge_delete] err: sql:SET @save_log_bin= @@sql_log_bin;: run \"SET @save_log_bin= @@sql_log_bin;\" at line 219 err Error 1193 (HY000): Unknown system variable 'sql_log_bin'"

https://github.com/PingCAP-QE/tidb-test/pull/2385 This one is the pr for mysql-test.

lance6716

rest lgtm

lance6716 · 2024-09-11T03:24:14Z

pkg/sessionctx/variable/sysvar.go

@@ -3467,10 +3465,6 @@ const (
 	InnodbFastShutdown = "innodb_fast_shutdown"
 	// InnodbLockWaitTimeout is the name for 'innodb_lock_wait_timeout' system variable.
 	InnodbLockWaitTimeout = "innodb_lock_wait_timeout"
-	// SQLLogBin is the name for 'sql_log_bin' system variable.


Maybe involve PM to decide if we should keep some level of compatibility with MySQL.

For sql_log_bin, we can't implement it in TiDB, so we may allow read it and forbid writing to it. For log_bin, seems this is a read-only variable in MySQL, we can also let TiDB always return OFF for it.

https://dev.mysql.com/doc/refman/8.4/en/replication-options-binary-log.html#sysvar_sql_log_bin

https://dev.mysql.com/doc/refman/8.4/en/replication-options-binary-log.html#sysvar_log_bin

TiDB has discarded binlog, which makes it inherently incompatible with MySQL in this aspect. Therefore, keeping the binlog-related parameters is also pointless. It is recommended to remove them as well.

ti-chi-bot · 2024-09-11T05:53:19Z

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Benjamin2037 · 2024-09-11T07:39:25Z

/retest

tiprow · 2024-09-11T07:39:49Z

@Benjamin2037: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lance6716 · 2024-09-11T09:09:51Z

/retest

tiprow · 2024-09-11T09:10:15Z

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Benjamin2037 · 2024-09-11T09:37:57Z

/cc ailinkid, tangenta, yudongusa

gengliqi · 2024-09-14T05:55:30Z

When can this PR be merged? I want to update tipb but found that the compiler will report an error because binlog part in tipb has been removed.

yudongusa

LGTM after confirmation with the team on the potential business impact mitigation.

Signed-off-by: Benjamin2037 <bear.c@pingcap.com>

ti-chi-bot · 2024-09-20T00:32:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Frank945946, lance6716, tangenta, winoros, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lance6716,tangenta,winoros]
~~pkg/config/OWNERS~~ [yudongusa]
~~pkg/ddl/OWNERS~~ [lance6716,tangenta]
~~pkg/domain/OWNERS~~ [lance6716,tangenta]
~~pkg/lightning/OWNERS~~ [lance6716]
~~pkg/parser/OWNERS~~ [tangenta,yudongusa]
~~pkg/planner/OWNERS~~ [winoros]
~~pkg/sessionctx/variable/OWNERS~~ [yudongusa]
~~pkg/table/OWNERS~~ [tangenta]
~~pkg/tidb-binlog/OWNERS~~ [lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/table/tblsession/table_test.go

lance6716 · 2024-09-20T02:10:41Z

/retest

tiprow · 2024-09-20T02:11:06Z

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2024

Benjamin2037 changed the title * : Remove binlog related codes. * : Remove binlog related codes(WIP) Sep 9, 2024

ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 9, 2024

This comment was marked as resolved.

Sign in to view

Benjamin2037 force-pushed the remove-binlog-codes branch from 8110a97 to 5c57523 Compare September 10, 2024 00:56

Benjamin2037 force-pushed the remove-binlog-codes branch from 1da47ca to 25c09f6 Compare September 10, 2024 01:37

Benjamin2037 changed the title * : Remove binlog related codes(WIP) * : Remove binlog related codes Sep 11, 2024

lance6716 reviewed Sep 11, 2024

View reviewed changes

lance6716 approved these changes Sep 11, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 11, 2024

Frank945946 approved these changes Sep 11, 2024

View reviewed changes

Benjamin2037 force-pushed the remove-binlog-codes branch 2 times, most recently from 981989a to 70039bb Compare September 11, 2024 08:15

Benjamin2037 requested a review from AilinKid September 11, 2024 09:38

yudongusa approved these changes Sep 19, 2024

View reviewed changes

ti-chi-bot bot added the approved label Sep 19, 2024

Benjamin2037 added 18 commits September 20, 2024 08:10

Remove binlog related codes.

1515ae3

Signed-off-by: Benjamin2037 <bear.c@pingcap.com>

Remove binlog related statements.

61fb51d

Signed-off-by: Benjamin2037 <bear.c@pingcap.com>

Edit bazel

75c7da1

fix test and build fail problems.

6076496

Signed-off-by: Benjamin2037 <bear.c@pingcap.com>

edit bazel

3037730

Edit reorg code

ee241d7

fix test and build fail.

44f601d

edit tests.

20ad094

Fix ut test fail.

1f48377

add binlog stmt & fix ut fail.

8844520

Fix ut fail

3f7e11b

fix realtikv fail case.

d703fe9

Fix realtikv case.

243cbe7

Remove pump and drainer related testcase.

f2a54f3

Remove ut binlog with savepoint case.

cb6d338

Edit bazel

b49af00

Bazel update

c53e1c3

Edit bazel and also remove binlog related funcs.

856d8f9

Benjamin2037 force-pushed the remove-binlog-codes branch from db77196 to 856d8f9 Compare September 20, 2024 00:31

This comment was marked as resolved.

Sign in to view

lance6716 reviewed Sep 20, 2024

View reviewed changes

pkg/table/tblsession/table_test.go Outdated Show resolved Hide resolved

Update pkg/table/tblsession/table_test.go

6413d19

ti-chi-bot bot merged commit 67bee7c into pingcap:master Sep 20, 2024
23 checks passed

Benjamin2037 deleted the remove-binlog-codes branch September 20, 2024 04:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

* : Remove binlog related codes #55955

* : Remove binlog related codes #55955

Benjamin2037 commented Sep 9, 2024 •

edited

Loading

tiprow bot commented Sep 9, 2024

This comment was marked as resolved.

Benjamin2037 commented Sep 9, 2024

tiprow bot commented Sep 9, 2024

codecov bot commented Sep 10, 2024 •

edited

Loading

Benjamin2037 commented Sep 11, 2024

tiprow bot commented Sep 11, 2024

Benjamin2037 commented Sep 11, 2024 •

edited

Loading

lance6716 left a comment

lance6716 Sep 11, 2024

Frank945946 Sep 11, 2024

ti-chi-bot bot commented Sep 11, 2024

Benjamin2037 commented Sep 11, 2024

tiprow bot commented Sep 11, 2024

lance6716 commented Sep 11, 2024

tiprow bot commented Sep 11, 2024

Benjamin2037 commented Sep 11, 2024

gengliqi commented Sep 14, 2024

yudongusa left a comment

ti-chi-bot bot commented Sep 20, 2024

This comment was marked as resolved.

lance6716 commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

* : Remove binlog related codes #55955

* : Remove binlog related codes #55955

Conversation

Benjamin2037 commented Sep 9, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Sep 9, 2024

This comment was marked as resolved.

Benjamin2037 commented Sep 9, 2024

tiprow bot commented Sep 9, 2024

codecov bot commented Sep 10, 2024 • edited Loading

Codecov Report

Benjamin2037 commented Sep 11, 2024

tiprow bot commented Sep 11, 2024

Benjamin2037 commented Sep 11, 2024 • edited Loading

lance6716 left a comment

Choose a reason for hiding this comment

lance6716 Sep 11, 2024

Choose a reason for hiding this comment

Frank945946 Sep 11, 2024

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 11, 2024

Benjamin2037 commented Sep 11, 2024

tiprow bot commented Sep 11, 2024

lance6716 commented Sep 11, 2024

tiprow bot commented Sep 11, 2024

Benjamin2037 commented Sep 11, 2024

gengliqi commented Sep 14, 2024

yudongusa left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 20, 2024

This comment was marked as resolved.

lance6716 commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

Benjamin2037 commented Sep 9, 2024 •

edited

Loading

codecov bot commented Sep 10, 2024 •

edited

Loading

Benjamin2037 commented Sep 11, 2024 •

edited

Loading