Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* : Remove binlog related codes #55955

Merged
merged 19 commits into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Edit bazel and also remove binlog related funcs.
  • Loading branch information
Benjamin2037 committed Sep 20, 2024
commit 856d8f9aa355f0deb683e859dddf2e5d612f03a1
6 changes: 0 additions & 6 deletions pkg/lightning/backend/kv/context.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,12 +181,6 @@ func (ctx *litTableMutateContext) GetReservedRowIDAlloc() (*stmtctx.ReservedRowI
return &ctx.reservedRowIDAlloc, true
}

// GetBinlogSupport implements the `table.MutateContext` interface.
func (*litTableMutateContext) GetBinlogSupport() (tblctx.BinlogSupport, bool) {
// lightning import does not support binlog.
return nil, false
}

// GetStatisticsSupport implements the `table.MutateContext` interface.
func (ctx *litTableMutateContext) GetStatisticsSupport() (tblctx.StatisticsSupport, bool) {
return ctx, true
Expand Down
2 changes: 0 additions & 2 deletions pkg/lightning/backend/kv/context_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,6 @@ func TestLitTableMutateContext(t *testing.T) {
require.NotNil(t, alloc)
require.Equal(t, &stmtctx.ReservedRowIDAlloc{}, alloc)
require.True(t, alloc.Exhausted())
_, ok = tblCtx.GetBinlogSupport()
require.False(t, ok)
_, ok = tblCtx.GetCachedTableSupport()
require.False(t, ok)
_, ok = tblCtx.GetTemporaryTableSupport()
Expand Down
1 change: 1 addition & 0 deletions pkg/table/tblsession/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ go_test(
flaky = True,
deps = [
":tblsession",
"//pkg/infoschema",
"//pkg/meta/model",
"//pkg/sessionctx/variable",
"//pkg/table",
Expand Down