Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a bug that nullable unique index can not find null values using index. #7163

Merged
merged 6 commits into from
Jul 27, 2018
Merged

fix a bug that nullable unique index can not find null values using index. #7163

merged 6 commits into from
Jul 27, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Jul 26, 2018

What have you changed? (mandatory)

Append 0 to the EndKey of the 'Is Null' index range. To make unique-key range [null, null] to be a scan rather than point-get in tikv.

See https://github.com/pingcap/tidb/blob/master/store/mockstore/mocktikv/executor.go#L289, and it will judge the range as point-get by:

// IsPoint checks if the key range represents a point.
func (r *KeyRange) IsPoint() bool {
	return bytes.Equal(r.StartKey.PrefixNext(), r.EndKey)
}

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

UT

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Does this PR need to be added to the release notes? (mandatory)

no

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@winkyao winkyao added the type/bugfix This PR fixes a bug. label Jul 26, 2018
@winkyao
Copy link
Contributor Author

winkyao commented Jul 26, 2018

@coocood @winoros PTAL

winoros
winoros reviewed Jul 26, 2018
View reviewed changes
distsql/request_builder.go
var hasNull bool
for _, highVal := range ran.HighVal {
if highVal.IsNull() {
hasNull = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could break at once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

util/ranger/types.go Outdated
@@ -67,6 +67,10 @@ func (ran *Range) IsPoint(sc *stmtctx.StatementContext) bool {
if cmp != 0 {
return false
}

if a.IsNull() && b.IsNull() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since cmp is 0. Compare once is enough?

distsql/request_builder.go Outdated
}

if hasNull {
// append 0 to make unique-key range [null, null] to be a scan rather than point-get.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize first character.

@winoros winoros added the sig/execution SIG execution label Jul 26, 2018
@winkyao
Copy link
Contributor Author

winkyao commented Jul 26, 2018

@winoros PTAL

winoros
winoros approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@winoros winoros added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2018
@winkyao
Copy link
Contributor Author

winkyao commented Jul 27, 2018

@coocood PTAL

zimulala
zimulala approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

/run-all-tests

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2018
@coocood
Copy link
Member

coocood commented Jul 27, 2018

LGTM

@winkyao
Copy link
Contributor Author

winkyao commented Jul 27, 2018

/run-all-tests

@winkyao
Copy link
Contributor Author

winkyao commented Jul 27, 2018

/run-unit-test

@winkyao winkyao merged commit f107fee into pingcap:master Jul 27, 2018
@winkyao winkyao deleted the fix_unique_null_get branch July 27, 2018 07:04
@winkyao winkyao mentioned this pull request Jul 27, 2018
Merged
coocood pushed a commit that referenced this pull request Jul 29, 2018
@winkyao @coocood
fix a bug that nullable unique index can not find null values using i…
1672248 
…ndex. (#7163) (#7172)
@eurekaka eurekaka mentioned this pull request Jul 1, 2020
Merged
@eurekaka eurekaka mentioned this pull request Aug 11, 2020
Merged
This was referenced Dec 27, 2022
Closed
Merged
This was referenced Jan 13, 2023
Merged
Closed
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winkyao @zimulala @coocood @winoros @ngaut