Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: not build dual for AntiSemiJoin when condition is constant false #8648

Merged
merged 4 commits into from
Dec 11, 2018
Merged

plan: not build dual for AntiSemiJoin when condition is constant false #8648

merged 4 commits into from
Dec 11, 2018

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Dec 11, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

Fix #8646

What is changed and how it works?

Check the join type before converting logical join to table dual.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Dec 11, 2018
@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka
Copy link
Contributor Author

@zz-jason @winoros @lamxTyler PTAL

zz-jason
zz-jason reviewed Dec 11, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 11, 2018
alivxxx
alivxxx approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 11, 2018
winoros
winoros approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@winoros winoros merged commit 080768d into pingcap:master Dec 11, 2018
@eurekaka eurekaka deleted the table_dual_anti branch December 11, 2018 09:52
iamzhoug37 pushed a commit to iamzhoug37/tidb that referenced this pull request Dec 13, 2018
@eurekaka @iamzhoug37
plan: not build dual for AntiSemiJoin when condition is constant false (
338200f 
pingcap#8648)
@eurekaka eurekaka mentioned this pull request Dec 18, 2018
Merged
@SeaRise SeaRise mentioned this pull request Jan 4, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@winoros winoros winoros approved these changes

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eurekaka @zz-jason @winoros @alivxxx