Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: not build dual for AntiSemiJoin when condition is constant false #8730

Merged
merged 2 commits into from
Dec 18, 2018
Merged

plan: not build dual for AntiSemiJoin when condition is constant false #8730

merged 2 commits into from
Dec 18, 2018

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Dec 18, 2018 •
edited by c4pt0r
Loading

cherry-pick #8648

This change is Reviewable

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Dec 18, 2018
@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@eurekaka
Copy link
Contributor Author

@zz-jason @winoros @lamxTyler PTAL

@alivxxx
Copy link
Contributor

alivxxx commented Dec 18, 2018

Do we need to cherry pick the test?

winoros
winoros reviewed Dec 18, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eurekaka
Copy link
Contributor Author

@lamxTyler release-2.1 branch does not contain this patch: #7842, so the test result is different, hence I dropped it.

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2018
alivxxx
alivxxx approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor Author

/rebuild

@jackysp jackysp merged commit c06df05 into pingcap:release-2.1 Dec 18, 2018
@eurekaka eurekaka deleted the pick_dual branch July 17, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eurekaka @alivxxx @winoros @jackysp